Remove WebPoint version of WebLayerImpl::setScrollPosition

cc/blink/web_layer_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_BLINK_WEB_LAYER_IMPL_H_
 #define CC_BLINK_WEB_LAYER_IMPL_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 85 matching lines @@
   virtual void setBackgroundFilters(const blink::WebFilterOperations& filters);
   virtual void setAnimationDelegate(
       blink::WebCompositorAnimationDelegate* delegate);
   virtual bool addAnimation(blink::WebCompositorAnimation* animation);
   virtual void removeAnimation(int animation_id);
   virtual void removeAnimation(int animation_id,
                                blink::WebCompositorAnimation::TargetProperty);
   virtual void pauseAnimation(int animation_id, double time_offset);
   virtual bool hasActiveAnimation();
   virtual void setForceRenderSurface(bool force);
-  // TODO(miletus): Add the WebDoublePoint version to WebLayer and then remove
-  // the WebPoint version from WebLayer and WebLayerImpl.
-  virtual void setScrollPosition(blink::WebPoint position);
-  virtual blink::WebPoint scrollPosition() const;
   virtual void setScrollPositionDouble(blink::WebDoublePoint position);
   virtual blink::WebDoublePoint scrollPositionDouble() const;
   virtual void setScrollClipLayer(blink::WebLayer* clip_layer);
   virtual bool scrollable() const;
   virtual void setUserScrollable(bool horizontal, bool vertical);
   virtual bool userScrollableHorizontal() const;
   virtual bool userScrollableVertical() const;
   virtual void setHaveWheelEventHandlers(bool have_wheel_event_handlers);
   virtual bool haveWheelEventHandlers() const;
   virtual void setHaveScrollEventHandlers(bool have_scroll_event_handlers);
   virtual bool haveScrollEventHandlers() const;
   virtual void setShouldScrollOnMainThread(bool scroll_on_main);
   virtual bool shouldScrollOnMainThread() const;
   virtual void setNonFastScrollableRegion(
       const blink::WebVector<blink::WebRect>& region);
   virtual blink::WebVector<blink::WebRect> nonFastScrollableRegion() const;
   virtual void setTouchEventHandlerRegion(
       const blink::WebVector<blink::WebRect>& region);
   virtual blink::WebVector<blink::WebRect> touchEventHandlerRegion() const;
   virtual void setIsContainerForFixedPositionLayers(bool is_container);
   virtual bool isContainerForFixedPositionLayers() const;
   virtual void setPositionConstraint(
       const blink::WebLayerPositionConstraint& constraint);
   virtual blink::WebLayerPositionConstraint positionConstraint() const;
   virtual void setScrollClient(blink::WebLayerScrollClient* client);
   virtual bool isOrphan() const;
   virtual void setWebLayerClient(blink::WebLayerClient* client);
 
   // LayerClient implementation.
-  virtual scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo()
-      override;
+  scoped_refptr<base::debug::ConvertableToTraceFormat> TakeDebugInfo() override;

[danakj, 2014/10/09 20:11:17]

i think clang plugin still complains about virtual with no override? anyhow this
is not related to this CL right?

[Yufeng Shen (Slow to review), 2014/10/09 20:13:02]

Yeah, presubmit complains about it so I thought I just fix it here.
Is the complain actually wrong ?

[danakj, 2014/10/09 20:14:11]

Do you know which presubmit check it is? (can you point me to it in cs?)

[jamesr, 2014/10/09 20:14:18]

Presubmit is wrong until the clang plugin actually rolls.

 
   virtual void setScrollParent(blink::WebLayer* parent);
   virtual void setClipParent(blink::WebLayer* parent);
 
  protected:
   scoped_refptr<cc::Layer> layer_;
   blink::WebLayerClient* web_layer_client_;
 
  private:
   scoped_ptr<WebToCCAnimationDelegateAdapter> animation_delegate_adapter_;
 
   DISALLOW_COPY_AND_ASSIGN(WebLayerImpl);
 };
 
 }  // namespace cc_blink
 
 #endif  // CC_BLINK_WEB_LAYER_IMPL_H_