Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: util/mac/mach_o_image_segment_reader_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mac/mach_o_image_reader_test.cc ('k') | util/mac/process_reader_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/mach_o_image_segment_reader_test.cc
diff --git a/util/mac/mach_o_image_segment_reader_test.cc b/util/mac/mach_o_image_segment_reader_test.cc
index 226eaa0715f15b7f14c575c2f0183b3cb0b1b467..d0e706f8b7121ff177b84769721bdd6208fc46d7 100644
--- a/util/mac/mach_o_image_segment_reader_test.cc
+++ b/util/mac/mach_o_image_segment_reader_test.cc
@@ -20,10 +20,10 @@
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-
// Most of MachOImageSegmentReader is tested as part of MachOImageReader, which
// depends on MachOImageSegmentReader to provide major portions of its
// functionality. Because MachOImageSegmentReader is difficult to use except by
@@ -184,3 +184,5 @@ TEST(MachOImageSegmentReader, SegmentAndSectionNameString) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mac/mach_o_image_reader_test.cc ('k') | util/mac/process_reader_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698