Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 635853002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/frame (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, Dmitry Titov
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/frame This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -149 lines) Patch
M Source/core/frame/BarProp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/Console.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/DOMTimer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/frame/EventHandlerRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameConsole.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 13 chunks +54 lines, -54 lines 0 comments Download
M Source/core/frame/History.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/ImageBitmap.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/frame/Location.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/Navigator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/PinchViewport.h View 2 chunks +25 lines, -25 lines 0 comments Download
M Source/core/frame/PlatformEventController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrame.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/RemoteFrameView.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/Screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/SuspendableTimer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/frame/csp/MediaListDirective.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/csp/SourceListDirective.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
MRV
Changes are in PTAL
6 years, 2 months ago (2014-10-07 13:22:29 UTC) #2
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 13:23:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635853002/1
6 years, 2 months ago (2014-10-07 13:26:44 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 15:34:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183344

Powered by Google App Engine
This is Rietveld 408576698