Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: Source/core/frame/FrameHost.h

Issue 635853002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/FrameConsole.h ('k') | Source/core/frame/FrameView.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 // FrameHost is the set of global data shared between multiple frames 51 // FrameHost is the set of global data shared between multiple frames
52 // and is provided by the embedder to each frame when created. 52 // and is provided by the embedder to each frame when created.
53 // FrameHost currently corresponds to the Page object in core/page 53 // FrameHost currently corresponds to the Page object in core/page
54 // however the concept of a Page is moving up out of Blink. 54 // however the concept of a Page is moving up out of Blink.
55 // In an out-of-process iframe world, a single Page may have 55 // In an out-of-process iframe world, a single Page may have
56 // multiple frames in different process, thus Page becomes a 56 // multiple frames in different process, thus Page becomes a
57 // browser-level concept and Blink core/ only knows about its LocalFrame (and Fr ameHost). 57 // browser-level concept and Blink core/ only knows about its LocalFrame (and Fr ameHost).
58 // Separating Page from the rest of core/ through this indirection 58 // Separating Page from the rest of core/ through this indirection
59 // allows us to slowly refactor Page without breaking the rest of core. 59 // allows us to slowly refactor Page without breaking the rest of core.
60 class FrameHost FINAL : public NoBaseWillBeGarbageCollectedFinalized<FrameHost> { 60 class FrameHost final : public NoBaseWillBeGarbageCollectedFinalized<FrameHost> {
61 WTF_MAKE_NONCOPYABLE(FrameHost); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED; 61 WTF_MAKE_NONCOPYABLE(FrameHost); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
62 public: 62 public:
63 static PassOwnPtrWillBeRawPtr<FrameHost> create(Page&); 63 static PassOwnPtrWillBeRawPtr<FrameHost> create(Page&);
64 ~FrameHost(); 64 ~FrameHost();
65 65
66 // Careful: This function will eventually be removed. 66 // Careful: This function will eventually be removed.
67 Page& page() const { return *m_page; } 67 Page& page() const { return *m_page; }
68 Settings& settings() const; 68 Settings& settings() const;
69 Chrome& chrome() const; 69 Chrome& chrome() const;
70 UseCounter& useCounter() const; 70 UseCounter& useCounter() const;
(...skipping 17 matching lines...) Expand all
88 RawPtrWillBeMember<Page> m_page; 88 RawPtrWillBeMember<Page> m_page;
89 const OwnPtr<PinchViewport> m_pinchViewport; 89 const OwnPtr<PinchViewport> m_pinchViewport;
90 const OwnPtrWillBeMember<EventHandlerRegistry> m_eventHandlerRegistry; 90 const OwnPtrWillBeMember<EventHandlerRegistry> m_eventHandlerRegistry;
91 91
92 AtomicString m_overrideEncoding; 92 AtomicString m_overrideEncoding;
93 }; 93 };
94 94
95 } 95 }
96 96
97 #endif // FrameHost_h 97 #endif // FrameHost_h
OLDNEW
« no previous file with comments | « Source/core/frame/FrameConsole.h ('k') | Source/core/frame/FrameView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698