Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 635733004: cc: Add ScopedWriteLock classes for raster to GpuMemoryBuffer or using Ganesh. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
Reviewers:
danakj, vmpstr, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add ScopedWriteLock classes for raster to GpuMemoryBuffer or using Ganesh. The refactor will allow ResourceProvider to use GpuMemoryBuffer instances directly and expose them to RasterWorkerPool implementations. This change is useful on its own as it cleans up the RasterWorkerPool code and makes implementations more consistent with BitmapRasterWorkerPool used for software compositing. It reduces the public API of the ResourceProvider class and eliminates the read lock fence API in favor of handling that as part of the resource provider implementation instead. BUG=418553 Committed: https://crrev.com/9fe3035db0b3993856ef57136c71105a6f99d3bc Cr-Commit-Position: refs/heads/master@{#298716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -248 lines) Patch
M cc/resources/gpu_raster_worker_pool.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M cc/resources/one_copy_raster_worker_pool.cc View 3 chunks +14 lines, -17 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.h View 4 chunks +40 lines, -19 lines 0 comments Download
M cc/resources/resource_provider.cc View 5 chunks +119 lines, -138 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 4 chunks +33 lines, -30 lines 0 comments Download
M cc/resources/zero_copy_raster_worker_pool.cc View 3 chunks +10 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reveman
Some cleanup in preparation for my CHROMIUM_image refactor. The patch that refactor CHROMIUM_image is pretty ...
6 years, 2 months ago (2014-10-07 14:36:17 UTC) #2
reveman
Here's the follow up refactor of CHROMIUM_image that moves map/unmap to the worker threads: https://codereview.chromium.org/634083002 ...
6 years, 2 months ago (2014-10-07 20:00:02 UTC) #3
piman
LGTM, I think it's a nice simplification to the API
6 years, 2 months ago (2014-10-07 20:50:08 UTC) #4
vmpstr
lgtm
6 years, 2 months ago (2014-10-08 15:46:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635733004/1
6 years, 2 months ago (2014-10-08 15:48:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 503a1e0881b348549346da976f84633e18da4769
6 years, 2 months ago (2014-10-08 15:52:19 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 15:52:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fe3035db0b3993856ef57136c71105a6f99d3bc
Cr-Commit-Position: refs/heads/master@{#298716}

Powered by Google App Engine
This is Rietveld 408576698