Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9785)

Unified Diff: cc/resources/one_copy_raster_worker_pool.cc

Issue 635733004: cc: Add ScopedWriteLock classes for raster to GpuMemoryBuffer or using Ganesh. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/gpu_raster_worker_pool.cc ('k') | cc/resources/pixel_buffer_raster_worker_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/one_copy_raster_worker_pool.cc
diff --git a/cc/resources/one_copy_raster_worker_pool.cc b/cc/resources/one_copy_raster_worker_pool.cc
index f447df54b79092986d7ee624e5e9cd2ad0993345..fba320f108f49e9456238ed395e15d9d7a62c397 100644
--- a/cc/resources/one_copy_raster_worker_pool.cc
+++ b/cc/resources/one_copy_raster_worker_pool.cc
@@ -28,25 +28,18 @@ class RasterBufferImpl : public RasterBuffer {
resource_pool_(resource_pool),
resource_(resource),
raster_resource_(resource_pool->AcquireResource(resource->size())),
- buffer_(NULL),
- stride_(0) {
- // Acquire and map image for raster resource.
- resource_provider_->AcquireImage(raster_resource_->id());
- buffer_ = resource_provider_->MapImage(raster_resource_->id(), &stride_);
- }
+ lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer(
+ resource_provider_,
+ raster_resource_->id())),
+ buffer_(NULL) {}
virtual ~RasterBufferImpl() {
- // First unmap image for raster resource.
- resource_provider_->UnmapImage(raster_resource_->id());
+ // First unlock raster resource.
+ lock_.reset();
// Copy contents of raster resource to |resource_|.
resource_provider_->CopyResource(raster_resource_->id(), resource_->id());
- // This RasterBuffer implementation provides direct access to the memory
- // used by the GPU. Read lock fences are required to ensure that we're not
- // trying to map a resource that is currently in-use by the GPU.
- resource_provider_->EnableReadLockFences(raster_resource_->id());
-
// Return raster resource to pool so it can be used by another RasterBuffer
// instance.
resource_pool_->ReleaseResource(raster_resource_.Pass());
@@ -54,11 +47,15 @@ class RasterBufferImpl : public RasterBuffer {
// Overridden from RasterBuffer:
virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() override {
+ buffer_ = lock_->gpu_memory_buffer();
if (!buffer_)
return skia::AdoptRef(SkCreateNullCanvas());
- RasterWorkerPool::AcquireBitmapForBuffer(
- &bitmap_, buffer_, resource_->format(), resource_->size(), stride_);
+ RasterWorkerPool::AcquireBitmapForBuffer(&bitmap_,
+ buffer_,
+ resource_->format(),
+ resource_->size(),
+ lock_->stride());
return skia::AdoptRef(new SkCanvas(bitmap_));
}
virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) override {
@@ -74,8 +71,8 @@ class RasterBufferImpl : public RasterBuffer {
ResourcePool* resource_pool_;
const Resource* resource_;
scoped_ptr<ScopedResource> raster_resource_;
- uint8_t* buffer_;
- int stride_;
+ scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> lock_;
+ void* buffer_;
SkBitmap bitmap_;
DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
« no previous file with comments | « cc/resources/gpu_raster_worker_pool.cc ('k') | cc/resources/pixel_buffer_raster_worker_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698