Issue 6356015: DevTools: enable remote debugging with front-end served from the cloud.

Issue 6356015: DevTools: enable remote debugging with front-end served from the cloud. (Closed)

Created:
9 years, 11 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DevTools: enable remote debugging with front-end served from the cloud. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73146

Patch Set 3 : Removed debugger wrapper. #

Patch Set 4 : Extra qualification removed. #

Total comments: 10

Patch Set 5 : Review comments addressed. #

Total comments: 1

Patch Set 6 : Lint #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -128 lines)			Patch
M	chrome/browser/browser_process.h	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	1 2	4 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1 2 3 4	5 chunks	+20 lines, -13 lines	0 comments	Download
D	chrome/browser/debugger/debugger_wrapper.h	View	1 2	1 chunk	+0 lines, -34 lines	0 comments	Download
D	chrome/browser/debugger/debugger_wrapper.cc	View	1 2	1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.h	View	1 2 3 4	2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View	1 2 3 4	5 chunks	+42 lines, -16 lines	0 comments	Download
M	chrome/browser/debugger/devtools_protocol_handler.h	View	1 2 3 4	2 chunks	+5 lines, -5 lines	0 comments	Download
	chrome/browser/debugger/devtools_protocol_handler.cc	View	1 2 3 4 5	1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1 2	1 chunk	+11 lines, -6 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/testing_browser_process.h	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/6356015/diff/8001/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/6356015/diff/8001/chrome/browser/browser_process_impl.cc#newcode465 chrome/browser/browser_process_impl.cc:465: devtools_http_handler_ = Please add DCHECK(CalledOnValidThread()); before this line. http://codereview.chromium.org/6356015/diff/8001/chrome/browser/debugger/devtools_http_protocol_handler.cc ...

9 years, 10 months ago (2011-01-31 14:58:24 UTC) #2

pfeldman

http://codereview.chromium.org/6356015/diff/8001/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/6356015/diff/8001/chrome/browser/browser_process_impl.cc#newcode465 chrome/browser/browser_process_impl.cc:465: devtools_http_handler_ = On 2011/01/31 14:58:24, Yury Semikhatsky wrote: > ...

9 years, 10 months ago (2011-01-31 15:15:54 UTC) #3

yurys

9 years, 10 months ago (2011-01-31 15:20:56 UTC) #4

LGTM

http://codereview.chromium.org/6356015/diff/7004/chrome/browser/debugger/devt...
File chrome/browser/debugger/devtools_protocol_handler.cc (right):

http://codereview.chromium.org/6356015/diff/7004/chrome/browser/debugger/devt...
chrome/browser/debugger/devtools_protocol_handler.cc:17:
scoped_refptr<DevToolsProtocolHandler> DevToolsProtocolHandler::Start(int port)
{
line is too long

Expand Messages | Collapse Messages