Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: chrome/browser/debugger/devtools_http_protocol_handler.h

Issue 6356015: DevTools: enable remote debugging with front-end served from the cloud. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Lint Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/debugger/devtools_http_protocol_handler.h
diff --git a/chrome/browser/debugger/devtools_http_protocol_handler.h b/chrome/browser/debugger/devtools_http_protocol_handler.h
index c5c485f2d4c51fd8c4c8728036f2a5af1a427b51..e28da6a1f8a55aab6546b7e29e321e0697052ae5 100644
--- a/chrome/browser/debugger/devtools_http_protocol_handler.h
+++ b/chrome/browser/debugger/devtools_http_protocol_handler.h
@@ -22,17 +22,20 @@ class DevToolsHttpProtocolHandler
public net::URLRequest::Delegate,
public base::RefCountedThreadSafe<DevToolsHttpProtocolHandler> {
public:
- explicit DevToolsHttpProtocolHandler(int port);
+ static scoped_refptr<DevToolsHttpProtocolHandler> Start(
+ int port,
+ const std::string& frontend_url);
- // This method should be called after the object construction.
- void Start();
-
- // This method should be called before the object destruction.
+ // Called from the main thread in order to stop protocol handler.
+ // Will schedule tear down task on IO thread.
void Stop();
private:
friend class base::RefCountedThreadSafe<DevToolsHttpProtocolHandler>;
+
+ DevToolsHttpProtocolHandler(int port, const std::string& frontend_url);
virtual ~DevToolsHttpProtocolHandler();
+ void Start();
// HttpListenSocket::Delegate implementation.
virtual void OnHttpRequest(HttpListenSocket* socket,
@@ -73,6 +76,7 @@ class DevToolsHttpProtocolHandler
TabContents* GetTabContents(int session_id);
int port_;
+ std::string overriden_frontend_url_;
scoped_refptr<HttpListenSocket> server_;
typedef std::map<net::URLRequest*, HttpListenSocket*>
RequestToSocketMap;
« no previous file with comments | « chrome/browser/debugger/debugger_wrapper.cc ('k') | chrome/browser/debugger/devtools_http_protocol_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698