ppapi/host/ppapi_host.cc - Issue 635593004: PPAPI: Make V8VarConverter longer-lived

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/host/ppapi_host.cc

Issue 635593004: PPAPI: Make V8VarConverter longer-lived (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/host/ppapi_host.cc

diff --git a/ppapi/host/ppapi_host.cc b/ppapi/host/ppapi_host.cc

index 130bc875569dcd61fe1d318ea682f5db927431a6..4878bc1daa74584284cac06c1a59919b98a3e07b 100644

--- a/ppapi/host/ppapi_host.cc

+++ b/ppapi/host/ppapi_host.cc

@@ -253,7 +253,7 @@ void PpapiHost::OnHostMsgAttachToPendingHost(PP_Resource pp_resource,

pending_resource_hosts_.find(pending_host_id);

if (found == pending_resource_hosts_.end()) {

// Plugin sent a bad ID.

- NOTREACHED();

+ //NOTREACHED();

raymes 2014/10/09 22:04:42 Was this getting hit?

dmichael (off chromium) 2014/10/09 22:45:37 Ah, good catch. It *was* getting hit; that was the

return;

}

found->second->SetPPResourceForPendingHost(pp_resource);