PPAPI: Make V8VarConverter longer-lived

ppapi/host/ppapi_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/host/ppapi_host.h"
 
 #include "base/logging.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/host/host_factory.h"
 #include "ppapi/host/host_message_context.h"
@@ skipping 235 matching lines @@
   resources_[params.pp_resource()] =
       linked_ptr<ResourceHost>(resource_host.release());
 }
 
 void PpapiHost::OnHostMsgAttachToPendingHost(PP_Resource pp_resource,
                                              int pending_host_id) {
   PendingHostResourceMap::iterator found =
       pending_resource_hosts_.find(pending_host_id);
   if (found == pending_resource_hosts_.end()) {
     // Plugin sent a bad ID.
-    NOTREACHED();
+    //NOTREACHED();

[raymes, 2014/10/09 22:04:42]

Was this getting hit?

[dmichael (off chromium), 2014/10/09 22:45:37]

Ah, good catch. It *was* getting hit; that was the symptom of the problem with
binding the PepperRendererHostImpl too early.

It was leftover from debugging; removed in the latest patch set.

     return;
   }
   found->second->SetPPResourceForPendingHost(pp_resource);
   resources_[pp_resource] = found->second;
   pending_resource_hosts_.erase(found);
 }
 
 void PpapiHost::OnHostMsgResourceDestroyed(PP_Resource resource) {
   ResourceMap::iterator found = resources_.find(resource);
   if (found == resources_.end()) {
     NOTREACHED();
     return;
   }
   // Invoking the HostResource destructor might result in looking up the
   // PP_Resource in resources_. std::map is not well specified as to whether the
   // element will be there or not. Therefore, we delay destruction of the
   // HostResource until after we've made sure the map no longer contains
   // |resource|.
   linked_ptr<ResourceHost> delete_at_end_of_scope(found->second);
   resources_.erase(found);
 }
 
 ResourceHost* PpapiHost::GetResourceHost(PP_Resource resource) const {
   ResourceMap::const_iterator found = resources_.find(resource);
   return found == resources_.end() ? NULL : found->second.get();
 }
 
 }  // namespace host
 }  // namespace ppapi