[DevTools] Move DOM domain overrides to DOMHandler

[DevTools] Move DOM domain overrides to DOMHandler

BUG=405566
Committed: https://crrev.com/a1dddd316a98b6ad28d6d20a1200ec3f141aeb95
Cr-Commit-Position: refs/heads/master@{#298723}

[vkuzkokov, 2014-10-07 15:09:41]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2014-10-07 15:27:26]

lgtm

https://codereview.chromium.org/635533004/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/dom_handler.cc (right):

https://codereview.chromium.org/635533004/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/dom_handler.cc:30:
ChildProcessSecurityPolicyImpl::GetInstance()->GrantReadFile(
I wonder why we never revoke permissions...

https://codereview.chromium.org/635533004/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/dom_handler.h (right):

https://codereview.chromium.org/635533004/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/dom_handler.h:27: void
SetRenderViewHost(RenderViewHostImpl* host);
I'd place non-protocol methods at the top for consistency with other handlers.

[vkuzkokov, 2014-10-08 11:12:25]

https://codereview.chromium.org/635533004/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/dom_handler.h (right):

https://codereview.chromium.org/635533004/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/dom_handler.h:27: void
SetRenderViewHost(RenderViewHostImpl* host);
On 2014/10/07 15:27:26, dgozman wrote:
> I'd place non-protocol methods at the top for consistency with other handlers.

Done.

[vkuzkokov, 2014-10-08 11:12:33]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-10-08 11:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635533004/20001

[commit-bot: I haz the power, 2014-10-08 11:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 11:15:48]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vkuzkokov, 2014-10-08 12:51:22]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-10-08 12:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635533004/40001

[commit-bot: I haz the power, 2014-10-08 13:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 13:32:32]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vkuzkokov, 2014-10-08 13:52:14]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-10-08 13:53:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635533004/60001

[commit-bot: I haz the power, 2014-10-08 14:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 14:36:51]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vkuzkokov, 2014-10-08 15:11:30]

The CQ bit was checked by vkuzkokov@chromium.org

[vkuzkokov, 2014-10-08 15:11:50]

The CQ bit was unchecked by vkuzkokov@chromium.org

[vkuzkokov, 2014-10-08 15:12:43]

Patchset #5 (id:80001) has been deleted

[vkuzkokov, 2014-10-08 15:13:19]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-10-08 15:13:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635533004/100001

[commit-bot: I haz the power, 2014-10-08 16:03:45]

Committed patchset #5 (id:100001) as a774faed0fdff40bbab8d0c0d417214e0e491fce

[commit-bot: I haz the power, 2014-10-08 16:04:31]

Patchset 5 (id:??) landed as
https://crrev.com/a1dddd316a98b6ad28d6d20a1200ec3f141aeb95
Cr-Commit-Position: refs/heads/master@{#298723}