Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: content/browser/devtools/render_view_devtools_agent_host.cc

Issue 635533004: [DevTools] Move DOM domain overrides to DOMHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for Windows again Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/render_view_devtools_agent_host.h" 5 #include "content/browser/devtools/render_view_devtools_agent_host.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/browser/child_process_security_policy_impl.h" 10 #include "content/browser/child_process_security_policy_impl.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 WebContents* web_contents = WebContents::FromRenderViewHost(pending); 103 WebContents* web_contents = WebContents::FromRenderViewHost(pending);
104 RenderViewDevToolsAgentHost* agent_host = FindAgentHost(web_contents); 104 RenderViewDevToolsAgentHost* agent_host = FindAgentHost(web_contents);
105 if (!agent_host) 105 if (!agent_host)
106 return; 106 return;
107 agent_host->DisconnectRenderViewHost(); 107 agent_host->DisconnectRenderViewHost();
108 agent_host->ConnectRenderViewHost(current); 108 agent_host->ConnectRenderViewHost(current);
109 } 109 }
110 110
111 RenderViewDevToolsAgentHost::RenderViewDevToolsAgentHost(RenderViewHost* rvh) 111 RenderViewDevToolsAgentHost::RenderViewDevToolsAgentHost(RenderViewHost* rvh)
112 : render_view_host_(NULL), 112 : render_view_host_(NULL),
113 dom_handler_(new devtools::dom::DOMHandler()),
113 input_handler_(new devtools::input::InputHandler()), 114 input_handler_(new devtools::input::InputHandler()),
114 page_handler_(new devtools::page::PageHandler()), 115 page_handler_(new devtools::page::PageHandler()),
115 handler_impl_(new DevToolsProtocolHandlerImpl()), 116 handler_impl_(new DevToolsProtocolHandlerImpl()),
116 overrides_handler_(new RendererOverridesHandler()), 117 overrides_handler_(new RendererOverridesHandler()),
117 tracing_handler_( 118 tracing_handler_(
118 new DevToolsTracingHandler(DevToolsTracingHandler::Renderer)), 119 new DevToolsTracingHandler(DevToolsTracingHandler::Renderer)),
119 power_handler_(new DevToolsPowerHandler()), 120 power_handler_(new DevToolsPowerHandler()),
120 reattaching_(false) { 121 reattaching_(false) {
122 handler_impl_->SetDOMHandler(dom_handler_.get());
121 handler_impl_->SetInputHandler(input_handler_.get()); 123 handler_impl_->SetInputHandler(input_handler_.get());
122 handler_impl_->SetPageHandler(page_handler_.get()); 124 handler_impl_->SetPageHandler(page_handler_.get());
123 SetRenderViewHost(rvh); 125 SetRenderViewHost(rvh);
124 DevToolsProtocol::Notifier notifier(base::Bind( 126 DevToolsProtocol::Notifier notifier(base::Bind(
125 &RenderViewDevToolsAgentHost::OnDispatchOnInspectorFrontend, 127 &RenderViewDevToolsAgentHost::OnDispatchOnInspectorFrontend,
126 base::Unretained(this))); 128 base::Unretained(this)));
127 handler_impl_->SetNotifier(notifier); 129 handler_impl_->SetNotifier(notifier);
128 overrides_handler_->SetNotifier(notifier); 130 overrides_handler_->SetNotifier(notifier);
129 tracing_handler_->SetNotifier(notifier); 131 tracing_handler_->SetNotifier(notifier);
130 power_handler_->SetNotifier(notifier); 132 power_handler_->SetNotifier(notifier);
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 page_handler_->OnVisibilityChanged(visible); 371 page_handler_->OnVisibilityChanged(visible);
370 } 372 }
371 } 373 }
372 374
373 void RenderViewDevToolsAgentHost::SetRenderViewHost(RenderViewHost* rvh) { 375 void RenderViewDevToolsAgentHost::SetRenderViewHost(RenderViewHost* rvh) {
374 DCHECK(!render_view_host_); 376 DCHECK(!render_view_host_);
375 render_view_host_ = static_cast<RenderViewHostImpl*>(rvh); 377 render_view_host_ = static_cast<RenderViewHostImpl*>(rvh);
376 378
377 WebContentsObserver::Observe(WebContents::FromRenderViewHost(rvh)); 379 WebContentsObserver::Observe(WebContents::FromRenderViewHost(rvh));
378 overrides_handler_->SetRenderViewHost(render_view_host_); 380 overrides_handler_->SetRenderViewHost(render_view_host_);
381 dom_handler_->SetRenderViewHost(render_view_host_);
379 input_handler_->SetRenderViewHost(render_view_host_); 382 input_handler_->SetRenderViewHost(render_view_host_);
380 page_handler_->SetRenderViewHost(render_view_host_); 383 page_handler_->SetRenderViewHost(render_view_host_);
381 384
382 registrar_.Add( 385 registrar_.Add(
383 this, 386 this,
384 content::NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED, 387 content::NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED,
385 content::Source<RenderWidgetHost>(render_view_host_)); 388 content::Source<RenderWidgetHost>(render_view_host_));
386 } 389 }
387 390
388 void RenderViewDevToolsAgentHost::ClearRenderViewHost() { 391 void RenderViewDevToolsAgentHost::ClearRenderViewHost() {
389 DCHECK(render_view_host_); 392 DCHECK(render_view_host_);
390 registrar_.Remove( 393 registrar_.Remove(
391 this, 394 this,
392 content::NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED, 395 content::NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED,
393 content::Source<RenderWidgetHost>(render_view_host_)); 396 content::Source<RenderWidgetHost>(render_view_host_));
394 render_view_host_ = NULL; 397 render_view_host_ = nullptr;
395 overrides_handler_->ClearRenderViewHost(); 398 overrides_handler_->ClearRenderViewHost();
396 input_handler_->SetRenderViewHost(NULL); 399 dom_handler_->SetRenderViewHost(nullptr);
397 page_handler_->SetRenderViewHost(NULL); 400 input_handler_->SetRenderViewHost(nullptr);
401 page_handler_->SetRenderViewHost(nullptr);
398 } 402 }
399 403
400 void RenderViewDevToolsAgentHost::DisconnectWebContents() { 404 void RenderViewDevToolsAgentHost::DisconnectWebContents() {
401 DisconnectRenderViewHost(); 405 DisconnectRenderViewHost();
402 } 406 }
403 407
404 void RenderViewDevToolsAgentHost::ConnectWebContents(WebContents* wc) { 408 void RenderViewDevToolsAgentHost::ConnectWebContents(WebContents* wc) {
405 ConnectRenderViewHost(wc->GetRenderViewHost()); 409 ConnectRenderViewHost(wc->GetRenderViewHost());
406 } 410 }
407 411
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 } 501 }
498 502
499 void RenderViewDevToolsAgentHost::OnDispatchOnInspectorFrontend( 503 void RenderViewDevToolsAgentHost::OnDispatchOnInspectorFrontend(
500 const std::string& message) { 504 const std::string& message) {
501 if (!render_view_host_) 505 if (!render_view_host_)
502 return; 506 return;
503 SendMessageToClient(message); 507 SendMessageToClient(message);
504 } 508 }
505 509
506 } // namespace content 510 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/render_view_devtools_agent_host.h ('k') | content/browser/devtools/renderer_overrides_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698