Give FrameTreeNodes a browser-global ID for use in navigation.

Give FrameTreeNodes a browser-global ID for use in navigation.

This is the first step in removing renderer-specific frame IDs.

BUG=314791
TEST=No visible change.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233827

[Charlie Reis, 2013-11-07 02:46:38]

Albert, can you take a look?

I was hoping to remove the renderer-specific frame ID from the FrameTreeNode as
well, but we still need it for the time being (since we may not have
RenderFrameHosts for each frame when the flag isn't passed).  Removing those IDs
can happen once we fix that.

[nasko, 2013-11-07 14:28:00]

Just a drive-by nit.

https://codereview.chromium.org/63523004/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree.h (right):

https://codereview.chromium.org/63523004/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree.h:95: // Returns the FrameTreeNode with
the given |frame_id|. For internal use only.
|frame_tree_node_id|?

[Charlie Reis, 2013-11-07 16:49:41]

https://codereview.chromium.org/63523004/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree.h (right):

https://codereview.chromium.org/63523004/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree.h:95: // Returns the FrameTreeNode with
the given |frame_id|. For internal use only.
On 2013/11/07 14:28:00, nasko wrote:
> |frame_tree_node_id|?

No, |frame_id| is the point of this function.  The public FindByID function
above takes in a |frame_tree_node_id|.  We need this for the time being to
support AddFrame and DetachFrame messages from the renderer process, which have
a renderer-specific frame ID.

[Charlie Reis, 2013-11-07 17:10:01]

https://codereview.chromium.org/63523004/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree.h (right):

https://codereview.chromium.org/63523004/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree.h:97: FrameTreeNode* FindByFrameID(int64
frame_tree_node_id);
Ah, here's the issue!  The parameter name was wrong.  Fixed.

[awong, 2013-11-07 17:31:57]

LGTM

[commit-bot: I haz the power, 2013-11-07 17:50:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/63523004/130001

[commit-bot: I haz the power, 2013-11-08 08:26:59]

Change committed as 233827