Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: content/browser/frame_host/frame_tree_node.cc

Issue 63523004: Give FrameTreeNodes a browser-global ID for use in navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update parameter name Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree_node.h" 5 #include "content/browser/frame_host/frame_tree_node.h"
6 6
7 #include <queue> 7 #include <queue>
8 8
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "content/browser/frame_host/render_frame_host_impl.h" 10 #include "content/browser/frame_host/render_frame_host_impl.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 const int64 FrameTreeNode::kInvalidFrameId = -1; 14 const int64 FrameTreeNode::kInvalidFrameId = -1;
15 int64 FrameTreeNode::next_frame_tree_node_id_ = 1;
15 16
16 FrameTreeNode::FrameTreeNode(int64 frame_id, const std::string& name, 17 FrameTreeNode::FrameTreeNode(int64 frame_id,
18 const std::string& name,
17 scoped_ptr<RenderFrameHostImpl> render_frame_host) 19 scoped_ptr<RenderFrameHostImpl> render_frame_host)
18 : frame_id_(frame_id), 20 : frame_tree_node_id_(next_frame_tree_node_id_++),
21 frame_id_(frame_id),
19 frame_name_(name), 22 frame_name_(name),
20 owns_render_frame_host_(true), 23 owns_render_frame_host_(true),
21 render_frame_host_(render_frame_host.release()) { 24 render_frame_host_(render_frame_host.release()) {
22 } 25 }
23 26
24 FrameTreeNode::~FrameTreeNode() { 27 FrameTreeNode::~FrameTreeNode() {
25 if (owns_render_frame_host_) 28 if (owns_render_frame_host_)
26 delete render_frame_host_; 29 delete render_frame_host_;
27 } 30 }
28 31
29 void FrameTreeNode::AddChild(scoped_ptr<FrameTreeNode> child) { 32 void FrameTreeNode::AddChild(scoped_ptr<FrameTreeNode> child) {
30 children_.push_back(child.release()); 33 children_.push_back(child.release());
31 } 34 }
32 35
33 void FrameTreeNode::RemoveChild(int64 child_id) { 36 void FrameTreeNode::RemoveChild(FrameTreeNode* child) {
34 std::vector<FrameTreeNode*>::iterator iter; 37 std::vector<FrameTreeNode*>::iterator iter;
35 38
36 for (iter = children_.begin(); iter != children_.end(); ++iter) { 39 for (iter = children_.begin(); iter != children_.end(); ++iter) {
37 if ((*iter)->frame_id() == child_id) 40 if ((*iter) == child)
38 break; 41 break;
39 } 42 }
40 43
41 if (iter != children_.end()) 44 if (iter != children_.end())
42 children_.erase(iter); 45 children_.erase(iter);
43 } 46 }
44 47
45 void FrameTreeNode::ResetForMainFrame( 48 void FrameTreeNode::ResetForMainFrame(
46 RenderFrameHostImpl* new_render_frame_host) { 49 RenderFrameHostImpl* new_render_frame_host) {
47 DCHECK_EQ(0UL, children_.size()); 50 DCHECK_EQ(0UL, children_.size());
48 51
49 owns_render_frame_host_ = false; 52 owns_render_frame_host_ = false;
50 frame_id_ = kInvalidFrameId; 53 frame_id_ = kInvalidFrameId;
51 current_url_ = GURL(); 54 current_url_ = GURL();
52 children_.clear(); 55 children_.clear();
53 56
54 render_frame_host_ = new_render_frame_host; 57 render_frame_host_ = new_render_frame_host;
55 } 58 }
56 59
57 } // namespace content 60 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/frame_tree_node.h ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698