Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 6349095: Merge 77355 - 2011-02-01 Mihai Parparita <mihaip@chromium.org>... (Closed)

Created:
9 years, 10 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 77355 - 2011-02-01 Mihai Parparita <mihaip@chromium.org>; Reviewed by James Robinson. Async event handlers should not fire within a modal dialog https://bugs.webkit.org/show_bug.cgi?id=53202 Add tests for a scroll event triggered right before a modal dialog is shown. * fast/events/scroll-event-during-modal-dialog-expected.txt: Added. * fast/events/scroll-event-during-modal-dialog.html: Added. 2011-02-01 Mihai Parparita <mihaip@chromium.org>; Reviewed by James Robinson. Async event handlers should not fire within a modal dialog https://bugs.webkit.org/show_bug.cgi?id=53202 Asychronous events that use EventQueue would currently fire while a modal dialog (e.g. window.alert()) was up. Change EventQueue to use a SuspendableTimer (which automatically gets suspended while dialogs are up and in other cases where JS execution is not allowed). Test: fast/events/scroll-event-during-modal-dialog.html * dom/Document.cpp: (WebCore::Document::Document): * dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired): * dom/EventQueue.h: (WebCore::EventQueue::create): * page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume): * page/SuspendableTimer.h: BUG=71888 TBR=jamesr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11303 lines, -15 lines) Patch
M LayoutTests/ChangeLog View 2 chunks +5112 lines, -0 lines 0 comments Download
A + LayoutTests/fast/events/scroll-event-during-modal-dialog.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +6140 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/EventQueue.h View 1 chunk +17 lines, -4 lines 0 comments Download
M Source/WebCore/dom/EventQueue.cpp View 2 chunks +24 lines, -7 lines 0 comments Download
M Source/WebCore/page/SuspendableTimer.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebCore/page/SuspendableTimer.cpp View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
9 years, 10 months ago (2011-02-04 01:32:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698