Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634883002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/page (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/page This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M Source/core/page/Chrome.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/CustomContextMenuProvider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/DOMWindowPagePopup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/page/FocusController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameTree.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/NetworkStateNotifierTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/PagePopupController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/page/PointerLockController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContextTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/ScopedPageLoadDeferrer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingConstraints.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:18:28 UTC) #2
Mike West
rs lgtm
6 years, 2 months ago (2014-10-07 13:04:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634883002/1
6 years, 2 months ago (2014-10-07 13:06:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:50:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183331

Powered by Google App Engine
This is Rietveld 408576698