Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: Source/core/page/PageLifecycleNotifier.h

Issue 634883002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/page (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/Page.h ('k') | Source/core/page/PagePopupController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "core/page/PageLifecycleObserver.h" 29 #include "core/page/PageLifecycleObserver.h"
30 #include "platform/LifecycleNotifier.h" 30 #include "platform/LifecycleNotifier.h"
31 #include "wtf/PassOwnPtr.h" 31 #include "wtf/PassOwnPtr.h"
32 #include "wtf/TemporaryChange.h" 32 #include "wtf/TemporaryChange.h"
33 33
34 namespace blink { 34 namespace blink {
35 35
36 class Page; 36 class Page;
37 class LocalFrame; 37 class LocalFrame;
38 38
39 class PageLifecycleNotifier FINAL : public LifecycleNotifier<Page> { 39 class PageLifecycleNotifier final : public LifecycleNotifier<Page> {
40 public: 40 public:
41 static PassOwnPtr<PageLifecycleNotifier> create(Page*); 41 static PassOwnPtr<PageLifecycleNotifier> create(Page*);
42 42
43 void notifyPageVisibilityChanged(); 43 void notifyPageVisibilityChanged();
44 void notifyDidCommitLoad(LocalFrame*); 44 void notifyDidCommitLoad(LocalFrame*);
45 45
46 virtual void addObserver(Observer*) OVERRIDE; 46 virtual void addObserver(Observer*) override;
47 virtual void removeObserver(Observer*) OVERRIDE; 47 virtual void removeObserver(Observer*) override;
48 48
49 private: 49 private:
50 explicit PageLifecycleNotifier(Page*); 50 explicit PageLifecycleNotifier(Page*);
51 51
52 typedef HashSet<PageLifecycleObserver*> PageObserverSet; 52 typedef HashSet<PageLifecycleObserver*> PageObserverSet;
53 PageObserverSet m_pageObservers; 53 PageObserverSet m_pageObservers;
54 }; 54 };
55 55
56 inline PassOwnPtr<PageLifecycleNotifier> PageLifecycleNotifier::create(Page* con text) 56 inline PassOwnPtr<PageLifecycleNotifier> PageLifecycleNotifier::create(Page* con text)
57 { 57 {
(...skipping 10 matching lines...) Expand all
68 inline void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame) 68 inline void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame)
69 { 69 {
70 TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverPageObs ervers); 70 TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverPageObs ervers);
71 for (PageObserverSet::iterator it = m_pageObservers.begin(); it != m_pageObs ervers.end(); ++it) 71 for (PageObserverSet::iterator it = m_pageObservers.begin(); it != m_pageObs ervers.end(); ++it)
72 (*it)->didCommitLoad(frame); 72 (*it)->didCommitLoad(frame);
73 } 73 }
74 74
75 } // namespace blink 75 } // namespace blink
76 76
77 #endif // PageLifecycleNotifier_h 77 #endif // PageLifecycleNotifier_h
OLDNEW
« no previous file with comments | « Source/core/page/Page.h ('k') | Source/core/page/PagePopupController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698