chrome/browser/sync/about_sync_util.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/about_sync_util.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/about_sync_util.cc

diff --git a/chrome/browser/sync/about_sync_util.cc b/chrome/browser/sync/about_sync_util.cc

index 055fd23c0bb832db0672facbcbfcf3f2de364da6..3cb86ac95235e8c7cfee9d5b11e9384afec5fa2c 100644

--- a/chrome/browser/sync/about_sync_util.cc

+++ b/chrome/browser/sync/about_sync_util.cc

@@ -143,8 +143,6 @@ std::string GetVersionString() {

// Build a version string that matches MakeUserAgentForSyncApi with the

// addition of channel info and proper OS names.

chrome::VersionInfo chrome_version;

- if (!chrome_version.is_valid())

- return "invalid";

// GetVersionStringModifier returns empty string for stable channel or

// unofficial builds, the channel string otherwise. We want to have "-devel"

// for unofficial builds only.

« no previous file with comments | « chrome/browser/signin/chrome_signin_client.cc ('k') | chrome/browser/sync/glue/local_device_info_provider_impl.cc » ('j') | no next file with comments »