Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2986)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/chrome_content_client_ios.mm

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mac, cros Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_content_client.cc ('k') | chrome/common/chrome_version_info.h » ('j') | chrome/common/chrome_version_info_values.h.version » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client_ios.mm
diff --git a/chrome/common/chrome_content_client_ios.mm b/chrome/common/chrome_content_client_ios.mm
index 52a8d3dc74d9e9a6cbe31617aec48b0952f14c7f..baee77c9329925cc766bc1719baca8ef4eecad4a 100644
--- a/chrome/common/chrome_content_client_ios.mm
+++ b/chrome/common/chrome_content_client_ios.mm
@@ -38,7 +38,7 @@ void ChromeContentClient::AddAdditionalSchemes(
std::string ChromeContentClient::GetProduct() const {
chrome::VersionInfo version_info;
std::string product("CriOS/");
- product += version_info.is_valid() ? version_info.Version() : "0.0.0.0";
+ product += version_info.Version();
return product;
}
« no previous file with comments | « chrome/common/chrome_content_client.cc ('k') | chrome/common/chrome_version_info.h » ('j') | chrome/common/chrome_version_info_values.h.version » ('J')

Powered by Google App Engine
This is Rietveld 408576698