chrome/common/chrome_content_client.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_content_client.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac, cros Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_content_client.cc

diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc

index 9e46c3a397ae4409903671bb5bd16f45fdea3b2a..d8da8c7381f9cee15ce6c3dd93fa9fd1b1a59b17 100644

--- a/chrome/common/chrome_content_client.cc

+++ b/chrome/common/chrome_content_client.cc

@@ -411,8 +411,7 @@ bool GetBundledPepperFlash(content::PepperPluginInfo* plugin) {

std::string GetProduct() {

chrome::VersionInfo version_info;

- return version_info.is_valid() ?

- version_info.ProductNameAndVersionForUserAgent() : std::string();

+ return version_info.ProductNameAndVersionForUserAgent();

}

} // namespace

« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/chrome_content_client_ios.mm » ('j') | chrome/common/chrome_version_info_values.h.version » ('J')