content/browser/accessibility/browser_accessibility_android.cc - Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu …

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing failure on win Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_win.cc » ('j') | content/test/data/accessibility/input-button-in-menu-expected-win.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 6f7c71f45f2b1bf8bc333661fad7b5b1bc942ce3..36c746dfa1bca670fbdd4643875884f49059908a 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -97,6 +97,7 @@ bool BrowserAccessibilityAndroid::IsCheckable() const {

GetAriaTristate("aria-pressed", &is_aria_pressed_defined, &is_mixed);

if (GetRole() == ui::AX_ROLE_CHECK_BOX ||

GetRole() == ui::AX_ROLE_RADIO_BUTTON ||

+ GetRole() == ui::AX_ROLE_CHECK_BOX_MENU_ITEM ||

dmazzoni 2014/10/08 18:59:15 Any reason not to do RADIO_MENU_ITEM in the same c

shreeramk 2014/10/08 19:38:51 Because for radio with menu as parent, MenuItemRol

dmazzoni 2014/10/08 19:41:40 Ah, OK - can you do that in a separate change?

is_aria_pressed_defined) {

checkable = true;

}

@@ -228,6 +229,7 @@ const char* BrowserAccessibilityAndroid::GetClassName() const {

class_name = "android.widget.Button";

break;

case ui::AX_ROLE_CHECK_BOX:

+ case ui::AX_ROLE_CHECK_BOX_MENU_ITEM:

class_name = "android.widget.CheckBox";

break;

case ui::AX_ROLE_RADIO_BUTTON: