Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu …

content/browser/accessibility/browser_accessibility_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_android.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/accessibility/browser_accessibility_manager_android.h"
 #include "content/common/accessibility_messages.h"
 
@@ skipping 79 matching lines @@
   return BrowserAccessibility::PlatformIsLeaf();
 }
 
 bool BrowserAccessibilityAndroid::IsCheckable() const {
   bool checkable = false;
   bool is_aria_pressed_defined;
   bool is_mixed;
   GetAriaTristate("aria-pressed", &is_aria_pressed_defined, &is_mixed);
   if (GetRole() == ui::AX_ROLE_CHECK_BOX ||
       GetRole() == ui::AX_ROLE_RADIO_BUTTON ||
+      GetRole() == ui::AX_ROLE_CHECK_BOX_MENU_ITEM ||

[dmazzoni, 2014/10/08 18:59:15]

Any reason not to do RADIO_MENU_ITEM in the same change? They're so similar, it
seems like it'd be easier to handle both at once.

[shreeramk, 2014/10/08 19:38:51]

Because for radio with menu as parent, MenuItemRole is returned from blink, if I
add  AX_ROLE_MENU_ITEM, then it would be applied on all where the role is
AX_ROLE_MENU_ITEM. 

The only solution for this would be introduce a new role in blink side for radio
with menu as parent.

[dmazzoni, 2014/10/08 19:41:40]

Ah, OK - can you do that in a separate change?

       is_aria_pressed_defined) {
     checkable = true;
   }
   if (HasState(ui::AX_STATE_CHECKED))
     checkable = true;
   return checkable;
 }
 
 bool BrowserAccessibilityAndroid::IsChecked() const {
   return HasState(ui::AX_STATE_CHECKED);
@@ skipping 111 matching lines @@
       break;
     case ui::AX_ROLE_COMBO_BOX:
       class_name = "android.widget.Spinner";
       break;
     case ui::AX_ROLE_BUTTON:
     case ui::AX_ROLE_MENU_BUTTON:
     case ui::AX_ROLE_POP_UP_BUTTON:
       class_name = "android.widget.Button";
       break;
     case ui::AX_ROLE_CHECK_BOX:
+    case ui::AX_ROLE_CHECK_BOX_MENU_ITEM:
       class_name = "android.widget.CheckBox";
       break;
     case ui::AX_ROLE_RADIO_BUTTON:
       class_name = "android.widget.RadioButton";
       break;
     case ui::AX_ROLE_TOGGLE_BUTTON:
       class_name = "android.widget.ToggleButton";
       break;
     case ui::AX_ROLE_CANVAS:
     case ui::AX_ROLE_IMAGE:
@@ skipping 403 matching lines @@
 int BrowserAccessibilityAndroid::CountChildrenWithRole(ui::AXRole role) const {
   int count = 0;
   for (uint32 i = 0; i < PlatformChildCount(); i++) {
     if (PlatformGetChild(i)->GetRole() == role)
       count++;
   }
   return count;
 }
 
 }  // namespace content