Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634483003: replace OVERRIDE and FINAL with override and final in mojo/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in mojo/ R=viettrungluu@chromium.org,dcheng@chromium.org BUG=417463 Committed: https://crrev.com/a1d1a22a5e946f117f67c3f7430313fe2089f4b5 Cr-Commit-Position: refs/heads/master@{#298279}

Patch Set 1 #

Total comments: 9

Patch Set 2 : remove compiler_specific.h inclusions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -250 lines) Patch
M mojo/services/native_viewport/platform_viewport_mac.mm View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_ozone.cc View 1 chunk +17 lines, -17 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_win.cc View 1 chunk +17 lines, -17 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_x11.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M mojo/services/native_viewport/viewport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/cookie_store_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/services/network/url_loader_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/network/web_socket_impl.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M mojo/services/public/cpp/input_events/lib/mojo_extended_key_event_data.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/bitmap_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +20 lines, -20 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.h View 1 2 chunks +11 lines, -12 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/services/view_manager/default_access_policy.h View 1 chunk +11 lines, -11 lines 0 comments Download
M mojo/services/view_manager/display_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 2 chunks +14 lines, -15 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M mojo/services/view_manager/window_manager_access_policy.h View 1 chunk +11 lines, -11 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M mojo/services/window_manager/window_manager_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/views/input_method_mojo_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/views/native_widget_view_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
viettrungluu
https://codereview.chromium.org/634483003/diff/1/mojo/services/network/url_loader_impl.h File mojo/services/network/url_loader_impl.h (right): https://codereview.chromium.org/634483003/diff/1/mojo/services/network/url_loader_impl.h#newcode8 mojo/services/network/url_loader_impl.h:8: #include "base/compiler_specific.h" Please remove this include. https://codereview.chromium.org/634483003/diff/1/mojo/services/network/web_socket_impl.h File mojo/services/network/web_socket_impl.h ...
6 years, 2 months ago (2014-10-06 16:12:21 UTC) #1
Mostyn Bramley-Moore
https://codereview.chromium.org/634483003/diff/1/mojo/services/network/url_loader_impl.h File mojo/services/network/url_loader_impl.h (right): https://codereview.chromium.org/634483003/diff/1/mojo/services/network/url_loader_impl.h#newcode8 mojo/services/network/url_loader_impl.h:8: #include "base/compiler_specific.h" On 2014/10/06 16:12:20, viettrungluu wrote: > Please ...
6 years, 2 months ago (2014-10-06 17:13:34 UTC) #2
viettrungluu
lgtm
6 years, 2 months ago (2014-10-06 17:35:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634483003/20001
6 years, 2 months ago (2014-10-06 17:42:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1b8a24db939eda15e5c6ebed9ca7ee79e93eab5c
6 years, 2 months ago (2014-10-06 18:19:30 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 18:22:53 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a1d1a22a5e946f117f67c3f7430313fe2089f4b5
Cr-Commit-Position: refs/heads/master@{#298279}

Powered by Google App Engine
This is Rietveld 408576698