Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 634403003: Adding webview tests to app_shell_browsertest. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding webview tests to app_shell_browsertest. This CL adds the following tests to app_shell_browsertest: - TestDialogAlert - TestDialogConfirm - TestDialogConfirmCancel - TestDialogConfirmDefaultCancel - TestDialogConfirmDefaultGCCancel - TestDialogPrompt Also, makes sure that we call content::BrowserTestBase::SetUpCommandLine(...) from AppShellTest. BUG=352293 Committed: https://crrev.com/19132ce1ce87227133c1f1da5ca027a1bda9f5e2 Cr-Commit-Position: refs/heads/master@{#299121}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 3 chunks +30 lines, -0 lines 0 comments Download
M extensions/shell/test/shell_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/test/data/web_view/dialog/embedder.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/dialog/embedder.js View 7 chunks +13 lines, -13 lines 0 comments Download
A + extensions/test/data/web_view/dialog/inject_dialog.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/dialog/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
A + extensions/test/data/web_view/dialog/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
lfg
lazyboy@chromium.org: Please review changes in *web_view* yoz@chromium.org: Please review changes in extensions/*
6 years, 2 months ago (2014-10-08 22:30:54 UTC) #2
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-08 22:36:52 UTC) #3
lazyboy
lgtm
6 years, 2 months ago (2014-10-08 23:23:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634403003/1
6 years, 2 months ago (2014-10-09 15:08:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634403003/80001
6 years, 2 months ago (2014-10-10 15:19:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 2 months ago (2014-10-10 15:46:30 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 15:50:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19132ce1ce87227133c1f1da5ca027a1bda9f5e2
Cr-Commit-Position: refs/heads/master@{#299121}

Powered by Google App Engine
This is Rietveld 408576698