Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 634403003: Adding webview tests to app_shell_browsertest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_apitest.h ('k') | extensions/shell/test/shell_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_apitest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc
index 81955e0705908e171ba6bca52bf522a42bcff2fc..ce956dd86435c0ae7020d48660c9474fcbc5d243 100644
--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc
@@ -9,6 +9,7 @@
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/api/test/test_api.h"
@@ -123,6 +124,11 @@ void WebViewAPITest::RunTestOnMainThreadLoop() {
GetGuestViewManager()->WaitForAllGuestsDeleted();
}
+void WebViewAPITest::SetUpCommandLine(base::CommandLine* command_line) {
+ AppShellTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose-gc");
+}
+
void WebViewAPITest::SetUpOnMainThread() {
AppShellTest::SetUpOnMainThread();
@@ -251,6 +257,30 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDestroyOnEventListener) {
RunTest("testDestroyOnEventListener", "web_view/apitest");
}
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogAlert) {
+ RunTest("testDialogAlert", "web_view/dialog");
+}
+
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogConfirm) {
+ RunTest("testDialogConfirm", "web_view/dialog");
+}
+
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogConfirmCancel) {
+ RunTest("testDialogConfirmCancel", "web_view/dialog");
+}
+
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogConfirmDefaultCancel) {
+ RunTest("testDialogConfirmDefaultCancel", "web_view/dialog");
+}
+
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogConfirmDefaultGCCancel) {
+ RunTest("testDialogConfirmDefaultGCCancel", "web_view/dialog");
+}
+
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogPrompt) {
+ RunTest("testDialogPrompt", "web_view/dialog");
+}
+
IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDisplayNoneWebviewLoad) {
RunTest("testDisplayNoneWebviewLoad", "web_view/apitest");
}
« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_apitest.h ('k') | extensions/shell/test/shell_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698