Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 634373003: Consolidate content fling implementations (Closed)

Created:
6 years, 2 months ago by jdduke (slow)
Modified:
6 years, 2 months ago
Reviewers:
sky, oshima, no sievers, tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Consolidate content fling implementations Provide a single implementation of WebGestureCurve, instead relying on platform-specific ui::GestureCurve implementations for core functionality. This eliminates the duplicated curve code used for content and view-targetted flings on Aura. BUG=420214 Committed: https://crrev.com/1d6fc87072bd9f8ea7908cb5af19d7ef6cd0e18c Cr-Commit-Position: refs/heads/master@{#299136}

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Owners #

Patch Set 4 : Fix GN build #

Total comments: 2

Patch Set 5 : Fix GN and athena #

Patch Set 6 : Fix comment #

Patch Set 7 : FromSecondsD #

Patch Set 8 : Fix win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -1424 lines) Patch
M athena/wm/window_overview_mode.cc View 1 2 3 4 5 6 1 chunk +7 lines, -6 lines 0 comments Download
M content/child/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 4 5 6 3 chunks +6 lines, -12 lines 0 comments Download
D content/child/fling_animator_impl_android.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/child/fling_animator_impl_android.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D content/child/touch_fling_gesture_curve.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/child/touch_fling_gesture_curve.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D content/child/touch_fling_gesture_curve_unittest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
A content/child/web_gesture_curve_impl.h View 1 2 3 4 5 6 7 1 chunk +53 lines, -0 lines 0 comments Download
A content/child/web_gesture_curve_impl.cc View 1 2 3 4 5 6 1 chunk +97 lines, -0 lines 0 comments Download
A + content/child/web_gesture_curve_impl_unittest.cc View 1 2 3 chunks +26 lines, -23 lines 0 comments Download
M content/content_child.gypi View 1 2 chunks +2 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 2 3 4 3 chunks +4 lines, -0 lines 0 comments Download
A + ui/events/android/OWNERS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + ui/events/android/scroller.h View 5 chunks +16 lines, -13 lines 0 comments Download
A + ui/events/android/scroller.cc View 1 2 11 chunks +113 lines, -81 lines 0 comments Download
A + ui/events/android/scroller_unittest.cc View 1 3 chunks +61 lines, -52 lines 0 comments Download
M ui/events/events.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
A ui/events/gesture_curve.h View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
M ui/events/gestures/fling_curve.h View 1 3 chunks +14 lines, -5 lines 0 comments Download
M ui/events/gestures/fling_curve.cc View 1 2 chunks +44 lines, -17 lines 0 comments Download
M ui/events/gestures/fling_curve_unittest.cc View 1 1 chunk +19 lines, -17 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/android/scroller.h View 1 chunk +0 lines, -148 lines 0 comments Download
D ui/gfx/android/scroller.cc View 1 chunk +0 lines, -444 lines 0 comments Download
D ui/gfx/android/scroller_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
jdduke (slow)
tdresser@: Could you take a look at ui/events (I think sadrul@ is out until the ...
6 years, 2 months ago (2014-10-09 19:56:04 UTC) #2
tdresser
ui/events LGTM. https://codereview.chromium.org/634373003/diff/160001/ui/events/gesture_curve.h File ui/events/gesture_curve.h (right): https://codereview.chromium.org/634373003/diff/160001/ui/events/gesture_curve.h#newcode13 ui/events/gesture_curve.h:13: // An abstraction of curve-base gesture motion, ...
6 years, 2 months ago (2014-10-09 20:22:57 UTC) #3
jdduke (slow)
PTAL for owner review, thanks. sky@: ui/events/BUILD.gn, ui/gfx/BUILD.gn, athena/ sievers@: content/child/OWNERS, content/child/blink_platform_impl.cc https://codereview.chromium.org/634373003/diff/160001/ui/events/gesture_curve.h File ui/events/gesture_curve.h ...
6 years, 2 months ago (2014-10-09 22:21:21 UTC) #5
no sievers
lgtm
6 years, 2 months ago (2014-10-10 00:52:49 UTC) #6
sky
+oshima for athena Files you asked me to review LGTM
6 years, 2 months ago (2014-10-10 02:21:53 UTC) #8
oshima
athena lgtm
6 years, 2 months ago (2014-10-10 08:25:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634373003/450001
6 years, 2 months ago (2014-10-10 14:54:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/23763)
6 years, 2 months ago (2014-10-10 16:19:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634373003/720001
6 years, 2 months ago (2014-10-10 16:41:39 UTC) #15
commit-bot: I haz the power
Committed patchset #8 (id:720001)
6 years, 2 months ago (2014-10-10 18:00:34 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:01:12 UTC) #17
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/1d6fc87072bd9f8ea7908cb5af19d7ef6cd0e18c
Cr-Commit-Position: refs/heads/master@{#299136}

Powered by Google App Engine
This is Rietveld 408576698