Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 63433002: Reenable PnaclHeaderTest, set up observer before navigating. (Closed)

Created:
7 years, 1 month ago by jvoung (off chromium)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Reenable PnaclHeaderTest, set up observer before navigating. Hopefully setting up the observer before loading the HTML will fix the flake. Not sure why I set things up in other order before =( In the test-fail logs, it looks like none of the Log events from JS are making it back to the test harness to print, but they are making it to the JS console. So, I'm assuming this is a sign that the observer isn't set up in time. BUG=315328 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/test/nacl/pnacl_header_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung (off chromium)
7 years, 1 month ago (2013-11-06 23:38:56 UTC) #1
jvoung (off chromium)
ping
7 years, 1 month ago (2013-11-11 19:10:34 UTC) #2
jvoung (off chromium)
ping
7 years, 1 month ago (2013-11-15 17:15:58 UTC) #3
Nick Bray (chromium)
LGTM
7 years, 1 month ago (2013-11-16 00:14:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/63433002/1
7 years, 1 month ago (2013-11-18 19:25:20 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 21:52:41 UTC) #6
Message was sent while issue was closed.
Change committed as 235824

Powered by Google App Engine
This is Rietveld 408576698