Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: chrome/test/nacl/pnacl_header_test.cc

Issue 63433002: Reenable PnaclHeaderTest, set up observer before navigating. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/pnacl_header_test.cc
diff --git a/chrome/test/nacl/pnacl_header_test.cc b/chrome/test/nacl/pnacl_header_test.cc
index 4f4e9c8734ac45d64a43cba0f71f68cc5e288477..213a5a2cce7fc46c7f973e6d89a01f53a9a544bd 100644
--- a/chrome/test/nacl/pnacl_header_test.cc
+++ b/chrome/test/nacl/pnacl_header_test.cc
@@ -48,13 +48,13 @@ void PnaclHeaderTest::TearDown() {
void PnaclHeaderTest::RunLoadTest(const std::string& url,
int expected_noncors,
int expected_cors) {
- ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(url));
- // Wait until the NMF and pexe are also loaded, not just the HTML.
- // Do this by waiting till the LoadTestMessageHandler responds.
LoadTestMessageHandler handler;
JavascriptTestObserver observer(
browser()->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost(),
&handler);
+ ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(url));
+ // Wait until the NMF and pexe are also loaded, not just the HTML.
+ // Do this by waiting till the LoadTestMessageHandler responds.
EXPECT_TRUE(observer.Run()) << handler.error_message();
EXPECT_TRUE(handler.test_passed()) << "Test failed.";
EXPECT_EQ(expected_noncors, noncors_loads_);
@@ -105,8 +105,7 @@ scoped_ptr<HttpResponse> PnaclHeaderTest::WatchForPexeFetch(
return http_response.PassAs<HttpResponse>();
}
-// Disabled: http://crbug.com/315328.
-IN_PROC_BROWSER_TEST_F(PnaclHeaderTest, DISABLED_TestHasPnaclHeader) {
+IN_PROC_BROWSER_TEST_F(PnaclHeaderTest, TestHasPnaclHeader) {
// Load 2 pexes, one same origin and one cross orgin.
RunLoadTest("/nacl/pnacl_request_header/pnacl_request_header.html", 1, 1);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698