Display dialog when app install succeeds / fails on Athena

chrome/browser/ui/extensions/extension_install_ui_factory.h

Index: chrome/browser/ui/extensions/extension_install_ui_factory.h
diff --git a/chrome/browser/ui/extensions/extension_install_ui_factory.h b/chrome/browser/ui/extensions/extension_install_ui_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..ed907d70160c2e6de47e154845654d39e960f459
--- /dev/null
+++ b/chrome/browser/ui/extensions/extension_install_ui_factory.h
@@ -0,0 +1,20 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_FACTORY_H_
+#define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_FACTORY_H_
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+class ExtensionInstallUI;
+
+extensions::ExtensionInstallUI* CreateExtensionInstallUI(

[Ken Rockot(use gerrit already), 2014/10/15 22:20:08]

Please return a scoped_ptr to enforce ownership transfer.

Though regarding the existence of "non-Android non-Athena" sources in the GYP, I
would really rather this just go away altogether. As far as I understand this,
you need some way of overriding ExtensionInstallUI creation within existing
//chrome code.

Here is my proposal:

We add a CreateInstallUI interface to ExtensionsBrowserClient. TestEBC and
ShellEBC implementations can return a dummy implementation of ExtensionInstallUI
for now (let's call it NullExtensionInstallUI). Then the ChromeEBC
implementation can be:

scoped_ptr<ExtensionInstallUI> ChromeExtensionsBrowserClient::CreateInstallUI(
    BrowserContext* context) {
#if defined(USE_ATHENA)
  ExtensionInstallUI* ui = athena::ExtensionsDelegate::Get(context)
      ->CreateExtensionInstallUI();
#else
  ExtensionInstallUI* ui = new ExtensionInstallUIDefault(context);
#endif
  return make_scoped_ptr(ui);
}

What do you think of this?

[pkotwicz, 2014/10/15 23:08:53]

To double check, with your proposal,
chrome/browser/extensions/chrome_extensions_browser_client.cc will depend on
Athena.

This will necessitate either:
Adding athena/extensions/public to chrome/browser/DEPS
OR
Creating chrome/browser/extensions/DEPS (And adding athena/extensions/public as
a dependency there)

+    content::BrowserContext* context);
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_FACTORY_H_