chrome/browser/ui/extensions/extension_install_ui_factory.h - Issue 634313004: Display dialog when app install succeeds / fails on Athena

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/extensions/extension_install_ui_factory.h

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_install_ui_default.cc ('k') | chrome/browser/ui/extensions/extension_install_ui_factory.cc » ('j') | chrome/chrome_browser_ui.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_FACTORY_H_

	6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_FACTORY_H_

	7

	8 namespace content {

	9 class BrowserContext;

	10 }

	11

	12 namespace extensions {

	13 class ExtensionInstallUI;

	14

	15 extensions::ExtensionInstallUI* CreateExtensionInstallUI(
	Ken Rockot(use gerrit already) 2014/10/15 22:20:08 Please return a scoped_ptr to enforce ownership tr Please return a scoped_ptr to enforce ownership transfer. Though regarding the existence of "non-Android non-Athena" sources in the GYP, I would really rather this just go away altogether. As far as I understand this, you need some way of overriding ExtensionInstallUI creation within existing //chrome code. Here is my proposal: We add a CreateInstallUI interface to ExtensionsBrowserClient. TestEBC and ShellEBC implementations can return a dummy implementation of ExtensionInstallUI for now (let's call it NullExtensionInstallUI). Then the ChromeEBC implementation can be: scoped_ptr<ExtensionInstallUI> ChromeExtensionsBrowserClient::CreateInstallUI( BrowserContext* context) { #if defined(USE_ATHENA) ExtensionInstallUI* ui = athena::ExtensionsDelegate::Get(context) ->CreateExtensionInstallUI(); #else ExtensionInstallUI* ui = new ExtensionInstallUIDefault(context); #endif return make_scoped_ptr(ui); } What do you think of this? pkotwicz 2014/10/15 23:08:53 To double check, with your proposal, chrome/browse To double check, with your proposal, chrome/browser/extensions/chrome_extensions_browser_client.cc will depend on Athena. This will necessitate either: Adding athena/extensions/public to chrome/browser/DEPS OR Creating chrome/browser/extensions/DEPS (And adding athena/extensions/public as a dependency there)
	16 content::BrowserContext* context);

	17

	18 } // namespace extensions

	19

	20 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_FACTORY_H_

OLD	NEW