Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 634273002: Revert of [Suggestions] Create ImageEncoder, to abstract away image encode/decode. (Closed)

Created:
6 years, 2 months ago by Mathieu
Modified:
6 years, 2 months ago
Reviewers:
jam, huangs, blundell
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Suggestions] Create ImageEncoder, to abstract away image encode/decode. (patchset #4 id:170001 of https://codereview.chromium.org/630073002/) Reason for revert: It is no longer needed, we decided on a different approach. Original issue's description: > [Suggestions] Create ImageEncoder, to abstract away image encode/decode. > > iOS can't depend on JPEG encoder. > > TBR=jam > BUG=387751, 409156 > > Committed: https://crrev.com/f5e2e2fa7303d699027095cd9b7cfb9462b585f6 > Cr-Commit-Position: refs/heads/master@{#298510} TBR=huangs@chromium.org,blundell@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=387751, 409156 Committed: https://crrev.com/60143a3967b0a687f05a166db2314f0495d1fe10 Cr-Commit-Position: refs/heads/master@{#298706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -176 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service_factory.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/suggestions.gypi View 2 chunks +1 line, -19 lines 0 comments Download
M components/suggestions/BUILD.gn View 2 chunks +0 lines, -14 lines 0 comments Download
D components/suggestions/image_encoder.h View 1 chunk +0 lines, -36 lines 0 comments Download
M components/suggestions/image_manager.h View 4 chunks +5 lines, -6 lines 0 comments Download
M components/suggestions/image_manager.cc View 4 chunks +25 lines, -5 lines 0 comments Download
M components/suggestions/image_manager_unittest.cc View 7 chunks +4 lines, -20 lines 0 comments Download
D components/suggestions/jpeg/jpeg_image_encoder.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/suggestions/jpeg/jpeg_image_encoder.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mathieu
Created Revert of [Suggestions] Create ImageEncoder, to abstract away image encode/decode.
6 years, 2 months ago (2014-10-08 14:50:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634273002/1
6 years, 2 months ago (2014-10-08 14:51:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b5b9d576cf7bc8aae11ad5eec9de20a9a57b8fe5
6 years, 2 months ago (2014-10-08 14:53:01 UTC) #3
blundell
LGTM Apologies for leading you in the wrong direction :(.
6 years, 2 months ago (2014-10-08 14:53:21 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 14:53:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60143a3967b0a687f05a166db2314f0495d1fe10
Cr-Commit-Position: refs/heads/master@{#298706}

Powered by Google App Engine
This is Rietveld 408576698