Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: components/suggestions.gypi

Issue 634273002: Revert of [Suggestions] Create ImageEncoder, to abstract away image encode/decode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gyp ('k') | components/suggestions/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/suggestions.gypi
diff --git a/components/suggestions.gypi b/components/suggestions.gypi
index 88c71353ca5f6e53cfa7bace4547960b0dbc9ec4..e03dc2199ea2793e1b3b1261008dd9ca751f624c 100644
--- a/components/suggestions.gypi
+++ b/components/suggestions.gypi
@@ -24,7 +24,6 @@
'sources': [
'suggestions/blacklist_store.cc',
'suggestions/blacklist_store.h',
- 'suggestions/image_encoder.h',
'suggestions/image_fetcher.h',
'suggestions/image_fetcher_delegate.h',
'suggestions/image_manager.cc',
@@ -45,22 +44,5 @@
},
'includes': [ '../build/protoc.gypi' ],
},
- # TODO(justincohen): iOS cannot depend on ui/gfx, so we should provide an
- # implementation of the image encoder, and put this target in a block that
- # excludes iOS.
- {
- # GN version: //components/suggestions:jpeg_image_encoder
- 'target_name': 'jpeg_image_encoder',
- 'type': 'static_library',
- 'dependencies': [
- '../base/base.gyp:base',
- '../ui/gfx/gfx.gyp:gfx',
- 'suggestions',
- ],
- 'sources': [
- 'suggestions/jpeg/jpeg_image_encoder.cc',
- 'suggestions/jpeg/jpeg_image_encoder.h',
- ],
- }
- ]
+ ],
}
« no previous file with comments | « components/components_tests.gyp ('k') | components/suggestions/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698