Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 633793002: Prompt for granting permission to access USB devices. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prompt for granting permission to access USB devices. extensions::DevicePermissionsPrompt may be implemented by an embedder of the extensions system to provide a way to prompt the user for permission to access a set of USB devices. This is expandable to other device types. Implementations for Chrome using the Views framework (for Chrome OS, Linux and Windows) and Cocoa (for OS X) are provided in this change. Screenshots are attached to bug 420317. BUG=352720, 420317 Committed: https://crrev.com/43a9462cd259b1a3c6cc961b28518ba6aac261e9 Cr-Commit-Position: refs/heads/master@{#299983}

Patch Set 1 #

Patch Set 2 : Rebased and added Cocoa UI. #

Patch Set 3 : Marked float literals to fix Windows build. #

Total comments: 35

Patch Set 4 : Added properly saved XIB from avi@, responded to review feedback. #

Total comments: 1

Patch Set 5 : One final nit. #

Patch Set 6 : Rename UsbDevicesChosen -> OnUsbDevicesChosen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1676 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/app/nibs/DevicePermissionsPrompt.xib View 1 2 3 1 chunk +791 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm View 1 2 3 4 5 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.h View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm View 1 2 3 4 5 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/extensions/device_permissions_dialog_view.h View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc View 1 2 3 4 5 1 chunk +180 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/chrome_nibs.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_nibs.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/browser/api/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A extensions/browser/api/device_permissions_prompt.h View 1 2 3 4 5 1 chunk +157 lines, -0 lines 0 comments Download
A extensions/browser/api/device_permissions_prompt.cc View 1 2 3 1 chunk +199 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/hid/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/api/usb/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D extensions/browser/api/usb_private/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Reilly Grant (use Gerrit)
Finnur, please look at the DevicePermissionsPrompt infrastructure and Views implementation. Avi, please look at the ...
6 years, 2 months ago (2014-10-15 00:15:29 UTC) #2
Avi (use Gerrit)
Cocoa side LGTM with nits. Ping me tomorrow while I'm in the office and I'll ...
6 years, 2 months ago (2014-10-15 01:57:47 UTC) #3
Finnur
https://codereview.chromium.org/633793002/diff/40001/extensions/browser/api/DEPS File extensions/browser/api/DEPS (right): https://codereview.chromium.org/633793002/diff/40001/extensions/browser/api/DEPS#newcode3 extensions/browser/api/DEPS:3: ] I'm not sure what all these DEPS changes ...
6 years, 2 months ago (2014-10-15 10:01:26 UTC) #4
Reilly Grant (use Gerrit)
https://codereview.chromium.org/633793002/diff/40001/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h File chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h (right): https://codereview.chromium.org/633793002/diff/40001/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h#newcode1 chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h:1: // Copyright (c) 2014 The Chromium Authors. All rights ...
6 years, 2 months ago (2014-10-15 19:15:34 UTC) #5
Finnur
LGTM, one nit. https://codereview.chromium.org/633793002/diff/40001/extensions/browser/api/DEPS File extensions/browser/api/DEPS (right): https://codereview.chromium.org/633793002/diff/40001/extensions/browser/api/DEPS#newcode3 extensions/browser/api/DEPS:3: ] Nope. https://codereview.chromium.org/633793002/diff/60001/chrome/browser/ui/views/extensions/device_permissions_dialog_view.h File chrome/browser/ui/views/extensions/device_permissions_dialog_view.h (right): ...
6 years, 2 months ago (2014-10-16 09:20:21 UTC) #6
Reilly Grant (use Gerrit)
Lei, please take a look at chrome/chrome_nibs.gyp.
6 years, 2 months ago (2014-10-16 17:31:02 UTC) #8
Lei Zhang
lgtm stamp
6 years, 2 months ago (2014-10-16 21:08:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633793002/100001
6 years, 2 months ago (2014-10-16 21:13:06 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-16 21:59:42 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 22:00:27 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/43a9462cd259b1a3c6cc961b28518ba6aac261e9
Cr-Commit-Position: refs/heads/master@{#299983}

Powered by Google App Engine
This is Rietveld 408576698