extensions/browser/api/DEPS - Issue 633793002: Prompt for granting permission to access USB devices.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/api/DEPS

Issue 633793002: Prompt for granting permission to access USB devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marked float literals to fix Windows build. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm ('K') | « chrome/chrome_nibs.gypi ('k') | extensions/browser/api/device_permissions_prompt.h » ('j') | extensions/browser/api/device_permissions_prompt.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+device/core",	2 "+device/core",

3 ]	3 ]
	Finnur 2014/10/15 10:01:25 I'm not sure what all these DEPS changes are for. I'm not sure what all these DEPS changes are for. Need I worry? Reilly Grant (use Gerrit) 2014/10/15 19:15:33 Nothing sneaky. Adding a dependency on device/usb Show quoted text On 2014/10/15 10:01:25, Finnur wrote: > I'm not sure what all these DEPS changes are for. Need I worry? Nothing sneaky. Adding a dependency on device/usb at the extensions/browser/api level just negated the need for it further down. I can keep the duplicated dependencies if people wish. Finnur 2014/10/16 09:20:21 Nope. Nope.
OLD	NEW