Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 63373003: [chromedriver] Add a WebView shell app for testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 7f6016ec2ed08eaf2a65879b2050dafbfdb07d29..f2db05781a84ceabe84598023bca11d427a12e50 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -126,6 +126,8 @@ _ANDROID_NEGATIVE_FILTER['org.chromium.chrome.testshell'] = (
'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly',
]
)
+_ANDROID_NEGATIVE_FILTER['org.chromium.chromedriver_webview_shell'] = (
+ _ANDROID_NEGATIVE_FILTER['org.chromium.chrome.testshell'])
class ChromeDriverBaseTest(unittest.TestCase):
@@ -145,9 +147,18 @@ class ChromeDriverBaseTest(unittest.TestCase):
def CreateDriver(self, server_url=None, **kwargs):
if server_url is None:
server_url = _CHROMEDRIVER_SERVER_URL
+
+ android_package=_ANDROID_PACKAGE
+ android_activity = None
+ android_process = None
+ if android_package and 'webview' in android_package:
+ android_activity = '.Main'
+ android_process = '%s:main' % android_package
driver = chromedriver.ChromeDriver(server_url,
chrome_binary=_CHROME_BINARY,
- android_package=_ANDROID_PACKAGE,
+ android_package=android_package,
+ android_activity=android_activity,
+ android_process=android_process,
**kwargs)
self._drivers += [driver]
return driver

Powered by Google App Engine
This is Rietveld 408576698