Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: chrome/test/chromedriver/chrome/device_manager.cc

Issue 63373003: [chromedriver] Add a WebView shell app for testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/device_manager.cc
diff --git a/chrome/test/chromedriver/chrome/device_manager.cc b/chrome/test/chromedriver/chrome/device_manager.cc
index 3e6469315dfd15459cd6220dd04de19db90d91ba..fa217ad9c252bfa9a7f2e5c698bd7b8f80803efd 100644
--- a/chrome/test/chromedriver/chrome/device_manager.cc
+++ b/chrome/test/chromedriver/chrome/device_manager.cc
@@ -58,7 +58,8 @@ Status Device::StartApp(const std::string& package,
device_socket = "chromium_testshell_devtools_remote";
command_line_file = "/data/local/tmp/chromium-testshell-command-line";
exec_name = "chromium_testshell";
- } else if (package.find("chrome") != std::string::npos) {
+ } else if (package.find("chrome") != std::string::npos &&
+ package.find("webview") == std::string::npos) {
craigdh 2013/11/07 23:26:59 this is starting to feel a bit hacky
frankf 2013/11/08 21:20:55 Any suggestions? We could list all chrome 4 chrome
craigdh 2013/11/11 17:55:43 No, I didn't have anything better in mind. Just a
known_activity = "com.google.android.apps.chrome.Main";
device_socket = "chrome_devtools_remote";
command_line_file = "/data/local/chrome-command-line";

Powered by Google App Engine
This is Rietveld 408576698