Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 633573004: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/dom (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/dom This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -333 lines) Patch
M Source/core/dom/Attr.h View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/CDATASection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/CSSSelectorWatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/CharacterData.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/ChildListMutationScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ChildNodeList.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/ClassCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRectList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Comment.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/ContextFeatures.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMException.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMSettableTokenList.h View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/DOMStringList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMURL.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.h View 12 chunks +38 lines, -38 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentFragment.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentInit.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarker.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarkerControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentType.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Element.h View 9 chunks +19 lines, -19 lines 0 comments Download
M Source/core/dom/ElementData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ElementDataCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EmptyNodeList.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContextTask.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/MainThreadTaskRunnerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/MessageChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/MutationObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationRecord.cpp View 7 chunks +27 lines, -27 lines 0 comments Download
M Source/core/dom/NameNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NamedNodeMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/NodeFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeListsNodeData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RawDataDocumentParser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/RenderedDocumentMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptableDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StaticNodeList.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/StringCallback.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/TemplateContentDocumentFragment.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Text.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Touch.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TouchList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/UserActionElementSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/XMLDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ContentDistribution.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:09:01 UTC) #2
Mike West
rs lgtm
6 years, 2 months ago (2014-10-07 13:04:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633573004/1
6 years, 2 months ago (2014-10-07 13:08:12 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 2 months ago (2014-10-07 14:11:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633573004/1
6 years, 2 months ago (2014-10-07 14:24:41 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:26:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183337

Powered by Google App Engine
This is Rietveld 408576698