Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 633563002: replace OVERRIDE and FINAL with override and final in ipc/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, mkwst+moarreviews-ipc_chromium.org, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in ipc/ BUG=417463 Committed: https://crrev.com/50a41f330c528275c2980d59dbe9d99d8aec2b49 Cr-Commit-Position: refs/heads/master@{#298413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -187 lines) Patch
M ipc/ipc_channel_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix.h View 3 chunks +13 lines, -13 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ipc/ipc_forwarding_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 44 chunks +48 lines, -48 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ipc/ipc_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_channel_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_readers.h View 4 chunks +8 lines, -8 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mostyn Bramley-Moore
@jeremy: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-06 15:31:14 UTC) #1
Mostyn Bramley-Moore
@cpu: can you PTAL (Jeremy is on vacation).
6 years, 2 months ago (2014-10-06 20:09:09 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 2 months ago (2014-10-06 23:38:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633563002/1
6 years, 2 months ago (2014-10-07 06:10:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as e9e0c187d78105b7dfb6eb900aea5bea7cbb7ac9
6 years, 2 months ago (2014-10-07 07:17:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 07:18:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50a41f330c528275c2980d59dbe9d99d8aec2b49
Cr-Commit-Position: refs/heads/master@{#298413}

Powered by Google App Engine
This is Rietveld 408576698