Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 63343004: Remove DialogDelegate::UseNewStyle and unused code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Additional cleanup; sync and rebase. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 65620bfdf844c259b685a99a0886e79d8459bf9d..5931ba80409502c01f2a97e2e8d897c9e4d37a11 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -1195,12 +1195,8 @@ void AutofillDialogViews::Show() {
delegate_->GetWebContents());
WebContentsModalDialogManagerDelegate* modal_delegate =
web_contents_modal_dialog_manager->delegate();
- DCHECK(modal_delegate);
sky 2013/11/16 03:03:16 How come you removed this?
msw 2013/11/16 04:15:44 I removed all these DCHECKs because I thought we t
sky 2013/11/18 17:03:10 I like DCHECKs like this as a way to document moda
-
window_ = views::Widget::CreateWindowAsFramelessChild(
- this,
- delegate_->GetWebContents()->GetView()->GetNativeView(),
- modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
+ this, modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
web_contents_modal_dialog_manager->ShowDialog(window_->GetNativeView());
focus_manager_ = window_->GetFocusManager();
focus_manager_->AddFocusChangeListener(this);

Powered by Google App Engine
This is Rietveld 408576698