Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 633413002: [DevTools] Move Network domain overrides to NetworkHandler (Closed)

Created:
6 years, 2 months ago by vkuzkokov
Modified:
6 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Network domain overrides to NetworkHandler BUG=405566 Committed: https://crrev.com/85a4118cb57b37ea38efd1dc64f48620d661c6d1 Cr-Commit-Position: refs/heads/master@{#299298}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -52 lines) Patch
M content/browser/devtools/protocol/network_handler.h View 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/network_handler.cc View 1 chunk +14 lines, -4 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 1 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vkuzkokov
6 years, 2 months ago (2014-10-08 13:43:54 UTC) #2
dgozman
lgtm
6 years, 2 months ago (2014-10-12 07:06:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633413002/30001
6 years, 2 months ago (2014-10-13 13:37:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:30001)
6 years, 2 months ago (2014-10-13 14:36:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 14:37:41 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/85a4118cb57b37ea38efd1dc64f48620d661c6d1
Cr-Commit-Position: refs/heads/master@{#299298}

Powered by Google App Engine
This is Rietveld 408576698