content/browser/devtools/render_view_devtools_agent_host.cc - Issue 633413002: [DevTools] Move Network domain overrides to NetworkHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.cc

Issue 633413002: [DevTools] Move Network domain overrides to NetworkHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/render_view_devtools_agent_host.h ('k') | content/browser/devtools/renderer_overrides_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/render_view_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_view_devtools_agent_host.cc b/content/browser/devtools/render_view_devtools_agent_host.cc

index 99febfdc903891805cfc5b608cf407d819024e69..88c39611bb992a65250175c923d36ab61cfc3595 100644

--- a/content/browser/devtools/render_view_devtools_agent_host.cc

+++ b/content/browser/devtools/render_view_devtools_agent_host.cc

@@ -111,6 +111,7 @@ RenderViewDevToolsAgentHost::RenderViewDevToolsAgentHost(RenderViewHost* rvh)

: render_view_host_(NULL),

dom_handler_(new devtools::dom::DOMHandler()),

input_handler_(new devtools::input::InputHandler()),

+ network_handler_(new devtools::network::NetworkHandler()),

page_handler_(new devtools::page::PageHandler()),

power_handler_(new devtools::power::PowerHandler()),

handler_impl_(new DevToolsProtocolHandlerImpl()),

@@ -120,6 +121,7 @@ RenderViewDevToolsAgentHost::RenderViewDevToolsAgentHost(RenderViewHost* rvh)

reattaching_(false) {

handler_impl_->SetDOMHandler(dom_handler_.get());

handler_impl_->SetInputHandler(input_handler_.get());

+ handler_impl_->SetNetworkHandler(network_handler_.get());

handler_impl_->SetPageHandler(page_handler_.get());

handler_impl_->SetPowerHandler(power_handler_.get());

SetRenderViewHost(rvh);

@@ -377,6 +379,7 @@ void RenderViewDevToolsAgentHost::SetRenderViewHost(RenderViewHost* rvh) {

overrides_handler_->SetRenderViewHost(render_view_host_);

dom_handler_->SetRenderViewHost(render_view_host_);

input_handler_->SetRenderViewHost(render_view_host_);

+ network_handler_->SetRenderViewHost(render_view_host_);

page_handler_->SetRenderViewHost(render_view_host_);

registrar_.Add(

@@ -395,6 +398,7 @@ void RenderViewDevToolsAgentHost::ClearRenderViewHost() {

overrides_handler_->ClearRenderViewHost();

dom_handler_->SetRenderViewHost(nullptr);

input_handler_->SetRenderViewHost(nullptr);

+ network_handler_->SetRenderViewHost(nullptr);

page_handler_->SetRenderViewHost(nullptr);

}