Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 633313004: Remove unused RFHManager::CreateViewAndSetSizeForRVH() method. (Closed)

Created:
6 years, 2 months ago by lazyboy
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused RFHManager::CreateViewAndSetSizeForRVH() method. The caller RenderViewHostManager::SwapInRenderViewHost() was deleted long time ago in http://codereview.chromium.org/8081019 BUG=None Test=No visible change, code cleanup. Committed: https://crrev.com/a9dc82b00bb039c5c583fbda80b2087bec817758 Cr-Commit-Position: refs/heads/master@{#298977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
6 years, 2 months ago (2014-10-09 19:12:57 UTC) #2
Charlie Reis
Thanks! LGTM.
6 years, 2 months ago (2014-10-09 19:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633313004/1
6 years, 2 months ago (2014-10-09 20:31:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 21:06:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 21:07:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9dc82b00bb039c5c583fbda80b2087bec817758
Cr-Commit-Position: refs/heads/master@{#298977}

Powered by Google App Engine
This is Rietveld 408576698