Remove unused RenderViewHostManager::SwapInRenderViewHost() and TabContents::SwapInRenderViewHost()

Remove unused RenderViewHostManager::SwapInRenderViewHost() and TabContents::SwapInRenderViewHost()


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103702

[Steve Block, 2011-09-30 13:07:53]

I came across this while trying to work out how RenderViewHostManager works. I
assume it's policy to remove such dead code?

[Charlie Reis, 2011-09-30 16:14:37]

Ah, great!  That was used for the prerendering code, but I had hoped to
eliminate the code duplication it had.  Chris, did the prerendering code get
refactored to not need this method anymore?

LGTM, but we should hear from Chris as well.

[cbentzel, 2011-09-30 16:31:20]

Not using it anymore - this was done when prerender was done with a
non-TabContents RenderViewHostDelegate, but now we use
SwapTabContents.

Thanks for stripping dead code!

On Fri, Sep 30, 2011 at 12:14 PM,  <creis@chromium.org> wrote:
> Ah, great!  That was used for the prerendering code, but I had hoped to
> eliminate the code duplication it had.  Chris, did the prerendering code get
> refactored to not need this method anymore?
>
> LGTM, but we should hear from Chris as well.
>
> http://codereview.chromium.org/8081019/
>

[commit-bot: I haz the power, 2011-09-30 18:11:35]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/8081019/1

[commit-bot: I haz the power, 2011-09-30 18:11:38]

Presubmit check for 8081019-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/tab_contents/tab_contents.cc,content/browser/tab_contents/render_view_host_manager.cc,content/browser/tab_contents/render_view_host_manager.h,content/browser/tab_contents/tab_contents.h

Presubmit checks took 1.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Steve Block, 2011-09-30 18:20:48]

+john for OWNERS LGTM

[jam, 2011-09-30 21:16:08]

woohoo lgtm

[commit-bot: I haz the power, 2011-10-02 19:46:09]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/8081019/1

[commit-bot: I haz the power, 2011-10-02 21:39:21]

Try job failure for 8081019-1 (retry) on win_rel for step "update".
It's a second try, previously, steps "update_scripts, browser_tests,
interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-03 09:18:23]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/8081019/8001

[commit-bot: I haz the power, 2011-10-03 10:59:27]

Change committed as 103702