content/shell/renderer/test_runner/web_ax_object_proxy.cc - Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_ax_object_proxy.cc

Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating expectations for android according to comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/accessibility/blink_ax_enum_conversion.cc ('k') | content/test/data/accessibility/aria-menuitemcheckbox.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/web_ax_object_proxy.cc

diff --git a/content/shell/renderer/test_runner/web_ax_object_proxy.cc b/content/shell/renderer/test_runner/web_ax_object_proxy.cc

index 6a87de673fdd77ca0de47465c7c6773e2a216aa8..256eea53916f98afab7ac1d11d3ae278d495994d 100644

--- a/content/shell/renderer/test_runner/web_ax_object_proxy.cc

+++ b/content/shell/renderer/test_runner/web_ax_object_proxy.cc

@@ -148,6 +148,10 @@ std::string RoleToString(blink::WebAXRole role)

return result.append("MenuButton");

case blink::WebAXRoleMenuItem:

return result.append("MenuItem");

+ case blink::WebAXRoleMenuItemCheckBox:

+ return result.append("MenuItemCheckBox");

+ case blink::WebAXRoleMenuItemRadio:

+ return result.append("MenuItemRadio");

case blink::WebAXRoleMenuListOption:

return result.append("MenuListOption");

case blink::WebAXRoleMenuListPopup: