content/renderer/accessibility/blink_ax_enum_conversion.cc - Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating expectations for android according to comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_browsertest.cc ('k') | content/shell/renderer/test_runner/web_ax_object_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_enum_conversion.cc

diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc

index 2f8efff43cc77396d49f0d44ed6241163cee51a4..f6fe8cd3a7632f6aa53f214b4dcd67df857b6992 100644

--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc

+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc

@@ -214,6 +214,10 @@ ui::AXRole AXRoleFromBlink(blink::WebAXRole role) {

return ui::AX_ROLE_MENU_BUTTON;

case blink::WebAXRoleMenuItem:

return ui::AX_ROLE_MENU_ITEM;

+ case blink::WebAXRoleMenuItemCheckBox:

+ return ui::AX_ROLE_MENU_ITEM_CHECK_BOX;

+ case blink::WebAXRoleMenuItemRadio:

+ return ui::AX_ROLE_MENU_ITEM_RADIO;

case blink::WebAXRoleMenuListOption:

return ui::AX_ROLE_MENU_LIST_OPTION;

case blink::WebAXRoleMenuListPopup: