content/browser/accessibility/browser_accessibility_win.cc - Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating expectations for android according to comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 13d0277c02d2531c50ce8f420c1677c4c87e53c5..1bc2a5a6a4fbc7885ef607b489ce98d4eb4c8641 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -2928,6 +2928,8 @@ void BrowserAccessibilityWin::OnDataChanged() {

if (ia_role_ == ROLE_SYSTEM_CHECKBUTTON ||

ia_role_ == ROLE_SYSTEM_RADIOBUTTON ||

+ ia2_role_ == IA2_ROLE_CHECK_MENU_ITEM ||

+ ia2_role_ == IA2_ROLE_RADIO_MENU_ITEM ||

ia2_role_ == IA2_ROLE_TOGGLE_BUTTON) {

ia2_attributes_.push_back(L"checkable:true");

}

@@ -3612,6 +3614,14 @@ void BrowserAccessibilityWin::InitRoleAndState() {

case ui::AX_ROLE_MENU_ITEM:

ia_role_ = ROLE_SYSTEM_MENUITEM;

break;

+ case ui::AX_ROLE_MENU_ITEM_CHECK_BOX:

+ ia_role_ = ROLE_SYSTEM_MENUITEM;

+ ia2_role_ = IA2_ROLE_CHECK_MENU_ITEM;

+ break;

+ case ui::AX_ROLE_MENU_ITEM_RADIO:

+ ia_role_ = ROLE_SYSTEM_MENUITEM;

+ ia2_role_ = IA2_ROLE_RADIO_MENU_ITEM;

+ break;

case ui::AX_ROLE_MENU_LIST_POPUP:

ia_role_ = ROLE_SYSTEM_CLIENT;

break;