content/browser/accessibility/browser_accessibility_android.cc - Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 633043002: Expose aria role menuitemcheckbox and menuitemradio with correct IA2 role.(Chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating expectations for android according to comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 6f7c71f45f2b1bf8bc333661fad7b5b1bc942ce3..dd1511d58de3308a89c7205f89997b717e649211 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -97,6 +97,8 @@ bool BrowserAccessibilityAndroid::IsCheckable() const {

GetAriaTristate("aria-pressed", &is_aria_pressed_defined, &is_mixed);

if (GetRole() == ui::AX_ROLE_CHECK_BOX ||

GetRole() == ui::AX_ROLE_RADIO_BUTTON ||

+ GetRole() == ui::AX_ROLE_MENU_ITEM_CHECK_BOX ||

+ GetRole() == ui::AX_ROLE_MENU_ITEM_RADIO ||

is_aria_pressed_defined) {

checkable = true;

}

« no previous file with comments | « chrome/common/extensions/api/automation.idl ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »