Issue 63213002: Have Blink be told of scrollbar changes rather than paying attention itself (Blink side part 2). - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(13)

My Issues | Starred Open | Closed | All

Issue 63213002: Have Blink be told of scrollbar changes rather than paying attention itself (Blink side part 2). (Closed)

Created:
7 years, 1 month ago by Avi (use Gerrit)

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have Blink be told of scrollbar changes rather than paying attention itself (Blink side part 2). BUG=306348 TEST=no visible change; scrollbar changes still work Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161654

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -62 lines)			Patch
	M	Source/core/platform/ScrollbarThemeMacCommon.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/platform/ScrollbarThemeMacCommon.mm	View	1 2	3 chunks	+0 lines, -61 lines	0 comments	Download
	M	Source/web/mac/WebScrollbarTheme.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

For after https://codereview.chromium.org/63203003 lands.

7 years, 1 month ago (2013-11-06 21:25:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/63213002/1

7 years, 1 month ago (2013-11-08 15:32:48 UTC) #3

commit-bot: I haz the power

Failed to apply patch for Source/core/platform/ScrollbarThemeMacCommon.mm: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 1 month ago (2013-11-08 15:32:51 UTC) #4

Failed to apply patch for Source/core/platform/ScrollbarThemeMacCommon.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/platform/ScrollbarThemeMacCommon.mm
  Hunk #2 FAILED at 287.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/platform/ScrollbarThemeMacCommon.mm.rej

Patch:       Source/core/platform/ScrollbarThemeMacCommon.mm
Index: Source/core/platform/ScrollbarThemeMacCommon.mm
diff --git a/Source/core/platform/ScrollbarThemeMacCommon.mm
b/Source/core/platform/ScrollbarThemeMacCommon.mm
index
9d8187c1659fad6d043d381a1b3bd4500630b9a4..dd299876c50e9ecd5fe6ad732ad31da1b2363c00
100644
--- a/Source/core/platform/ScrollbarThemeMacCommon.mm
+++ b/Source/core/platform/ScrollbarThemeMacCommon.mm
@@ -70,56 +70,6 @@ static ScrollbarSet& scrollbarSet()
 
 }
 
-@interface WebScrollbarPrefsObserver : NSObject
-{
-}
-
-+ (void)registerAsObserver;
-+ (void)appearancePrefsChanged:(NSNotification*)theNotification;
-+ (void)behaviorPrefsChanged:(NSNotification*)theNotification;
-
-@end
-
-@implementation WebScrollbarPrefsObserver
-
-+ (void)appearancePrefsChanged:(NSNotification*)unusedNotification
-{
-    UNUSED_PARAM(unusedNotification);
-
-    ScrollbarTheme* theme = ScrollbarTheme::theme();
-    if (theme->isMockTheme())
-        return;
-
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults synchronize];
-   
static_cast<ScrollbarThemeMacCommon*>(ScrollbarTheme::theme())->preferencesChanged(
-        [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-        [defaults boolForKey:@"AppleScrollerPagingBehavior"], true);
-}
-
-+ (void)behaviorPrefsChanged:(NSNotification*)unusedNotification
-{
-    UNUSED_PARAM(unusedNotification);
-
-    ScrollbarTheme* theme = ScrollbarTheme::theme();
-    if (theme->isMockTheme())
-        return;
-
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults synchronize];
-   
static_cast<ScrollbarThemeMacCommon*>(ScrollbarTheme::theme())->preferencesChanged(
-        [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-        [defaults boolForKey:@"AppleScrollerPagingBehavior"], false);
-}
-
-+ (void)registerAsObserver
-{
-    [[NSDistributedNotificationCenter defaultCenter] addObserver:self
selector:@selector(appearancePrefsChanged:)
name:@"AppleAquaScrollBarVariantChanged" object:nil
suspensionBehavior:NSNotificationSuspensionBehaviorDeliverImmediately];
-    [[NSDistributedNotificationCenter defaultCenter] addObserver:self
selector:@selector(behaviorPrefsChanged:)
name:@"AppleNoRedisplayAppearancePreferenceChanged" object:nil
suspensionBehavior:NSNotificationSuspensionBehaviorCoalesce];
-}
-
-@end
-
 namespace WebCore {
 
 static float gInitialButtonDelay = 0.5f;
@@ -337,16 +287,6 @@ void
ScrollbarThemeMacCommon::paintTickmarks(GraphicsContext* context, Scrollbar
 
 ScrollbarThemeMacCommon::ScrollbarThemeMacCommon()
 {
-    static bool initialized;
-    if (!initialized) {
-        initialized = true;
-        [WebScrollbarPrefsObserver registerAsObserver];
-        NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-        [defaults synchronize];
-        preferencesChanged(
-            [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-            [defaults boolForKey:@"AppleScrollerPagingBehavior"], false);
-    }
 }
 
 ScrollbarThemeMacCommon::~ScrollbarThemeMacCommon()

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/63213002/80001

7 years, 1 month ago (2013-11-08 16:36:55 UTC) #5

commit-bot: I haz the power

Failed to apply patch for Source/core/platform/ScrollbarThemeMacCommon.mm: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 1 month ago (2013-11-08 16:36:56 UTC) #6

Failed to apply patch for Source/core/platform/ScrollbarThemeMacCommon.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/platform/ScrollbarThemeMacCommon.mm
  Hunk #2 FAILED at 287.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/platform/ScrollbarThemeMacCommon.mm.rej

Patch:       Source/core/platform/ScrollbarThemeMacCommon.mm
Index: Source/core/platform/ScrollbarThemeMacCommon.mm
diff --git a/Source/core/platform/ScrollbarThemeMacCommon.mm
b/Source/core/platform/ScrollbarThemeMacCommon.mm
index
9d8187c1659fad6d043d381a1b3bd4500630b9a4..dd299876c50e9ecd5fe6ad732ad31da1b2363c00
100644
--- a/Source/core/platform/ScrollbarThemeMacCommon.mm
+++ b/Source/core/platform/ScrollbarThemeMacCommon.mm
@@ -70,56 +70,6 @@ static ScrollbarSet& scrollbarSet()
 
 }
 
-@interface WebScrollbarPrefsObserver : NSObject
-{
-}
-
-+ (void)registerAsObserver;
-+ (void)appearancePrefsChanged:(NSNotification*)theNotification;
-+ (void)behaviorPrefsChanged:(NSNotification*)theNotification;
-
-@end
-
-@implementation WebScrollbarPrefsObserver
-
-+ (void)appearancePrefsChanged:(NSNotification*)unusedNotification
-{
-    UNUSED_PARAM(unusedNotification);
-
-    ScrollbarTheme* theme = ScrollbarTheme::theme();
-    if (theme->isMockTheme())
-        return;
-
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults synchronize];
-   
static_cast<ScrollbarThemeMacCommon*>(ScrollbarTheme::theme())->preferencesChanged(
-        [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-        [defaults boolForKey:@"AppleScrollerPagingBehavior"], true);
-}
-
-+ (void)behaviorPrefsChanged:(NSNotification*)unusedNotification
-{
-    UNUSED_PARAM(unusedNotification);
-
-    ScrollbarTheme* theme = ScrollbarTheme::theme();
-    if (theme->isMockTheme())
-        return;
-
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults synchronize];
-   
static_cast<ScrollbarThemeMacCommon*>(ScrollbarTheme::theme())->preferencesChanged(
-        [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-        [defaults boolForKey:@"AppleScrollerPagingBehavior"], false);
-}
-
-+ (void)registerAsObserver
-{
-    [[NSDistributedNotificationCenter defaultCenter] addObserver:self
selector:@selector(appearancePrefsChanged:)
name:@"AppleAquaScrollBarVariantChanged" object:nil
suspensionBehavior:NSNotificationSuspensionBehaviorDeliverImmediately];
-    [[NSDistributedNotificationCenter defaultCenter] addObserver:self
selector:@selector(behaviorPrefsChanged:)
name:@"AppleNoRedisplayAppearancePreferenceChanged" object:nil
suspensionBehavior:NSNotificationSuspensionBehaviorCoalesce];
-}
-
-@end
-
 namespace WebCore {
 
 static float gInitialButtonDelay = 0.5f;
@@ -337,16 +287,6 @@ void
ScrollbarThemeMacCommon::paintTickmarks(GraphicsContext* context, Scrollbar
 
 ScrollbarThemeMacCommon::ScrollbarThemeMacCommon()
 {
-    static bool initialized;
-    if (!initialized) {
-        initialized = true;
-        [WebScrollbarPrefsObserver registerAsObserver];
-        NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-        [defaults synchronize];
-        preferencesChanged(
-            [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-            [defaults boolForKey:@"AppleScrollerPagingBehavior"], false);
-    }
 }
 
 ScrollbarThemeMacCommon::~ScrollbarThemeMacCommon()

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/63213002/80001

7 years, 1 month ago (2013-11-08 16:37:34 UTC) #7

commit-bot: I haz the power

Failed to apply patch for Source/core/platform/ScrollbarThemeMacCommon.mm: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 1 month ago (2013-11-08 16:37:36 UTC) #8

Failed to apply patch for Source/core/platform/ScrollbarThemeMacCommon.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/platform/ScrollbarThemeMacCommon.mm
  Hunk #2 FAILED at 287.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/platform/ScrollbarThemeMacCommon.mm.rej

Patch:       Source/core/platform/ScrollbarThemeMacCommon.mm
Index: Source/core/platform/ScrollbarThemeMacCommon.mm
diff --git a/Source/core/platform/ScrollbarThemeMacCommon.mm
b/Source/core/platform/ScrollbarThemeMacCommon.mm
index
9d8187c1659fad6d043d381a1b3bd4500630b9a4..dd299876c50e9ecd5fe6ad732ad31da1b2363c00
100644
--- a/Source/core/platform/ScrollbarThemeMacCommon.mm
+++ b/Source/core/platform/ScrollbarThemeMacCommon.mm
@@ -70,56 +70,6 @@ static ScrollbarSet& scrollbarSet()
 
 }
 
-@interface WebScrollbarPrefsObserver : NSObject
-{
-}
-
-+ (void)registerAsObserver;
-+ (void)appearancePrefsChanged:(NSNotification*)theNotification;
-+ (void)behaviorPrefsChanged:(NSNotification*)theNotification;
-
-@end
-
-@implementation WebScrollbarPrefsObserver
-
-+ (void)appearancePrefsChanged:(NSNotification*)unusedNotification
-{
-    UNUSED_PARAM(unusedNotification);
-
-    ScrollbarTheme* theme = ScrollbarTheme::theme();
-    if (theme->isMockTheme())
-        return;
-
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults synchronize];
-   
static_cast<ScrollbarThemeMacCommon*>(ScrollbarTheme::theme())->preferencesChanged(
-        [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-        [defaults boolForKey:@"AppleScrollerPagingBehavior"], true);
-}
-
-+ (void)behaviorPrefsChanged:(NSNotification*)unusedNotification
-{
-    UNUSED_PARAM(unusedNotification);
-
-    ScrollbarTheme* theme = ScrollbarTheme::theme();
-    if (theme->isMockTheme())
-        return;
-
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults synchronize];
-   
static_cast<ScrollbarThemeMacCommon*>(ScrollbarTheme::theme())->preferencesChanged(
-        [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-        [defaults boolForKey:@"AppleScrollerPagingBehavior"], false);
-}
-
-+ (void)registerAsObserver
-{
-    [[NSDistributedNotificationCenter defaultCenter] addObserver:self
selector:@selector(appearancePrefsChanged:)
name:@"AppleAquaScrollBarVariantChanged" object:nil
suspensionBehavior:NSNotificationSuspensionBehaviorDeliverImmediately];
-    [[NSDistributedNotificationCenter defaultCenter] addObserver:self
selector:@selector(behaviorPrefsChanged:)
name:@"AppleNoRedisplayAppearancePreferenceChanged" object:nil
suspensionBehavior:NSNotificationSuspensionBehaviorCoalesce];
-}
-
-@end
-
 namespace WebCore {
 
 static float gInitialButtonDelay = 0.5f;
@@ -337,16 +287,6 @@ void
ScrollbarThemeMacCommon::paintTickmarks(GraphicsContext* context, Scrollbar
 
 ScrollbarThemeMacCommon::ScrollbarThemeMacCommon()
 {
-    static bool initialized;
-    if (!initialized) {
-        initialized = true;
-        [WebScrollbarPrefsObserver registerAsObserver];
-        NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-        [defaults synchronize];
-        preferencesChanged(
-            [defaults floatForKey:@"NSScrollerButtonDelay"], [defaults
floatForKey:@"NSScrollerButtonPeriod"],
-            [defaults boolForKey:@"AppleScrollerPagingBehavior"], false);
-    }
 }
 
 ScrollbarThemeMacCommon::~ScrollbarThemeMacCommon()

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/63213002/150001

7 years, 1 month ago (2013-11-08 22:02:52 UTC) #9

Message was sent while issue was closed.

Change committed as 161654

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698