Have Blink be told of scrollbar changes rather than paying attention itself (Chromium side).

Have Blink be told of scrollbar changes rather than paying attention itself (Chromium side).

BUG=306348
TEST=no visible change; scrollbar changes still work

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233826

[Avi (use Gerrit), 2013-11-06 21:27:59]

John, I wanted you to look over the architecture of this to see if this is right
before I bring in the Mac and security guys.

[jam, 2013-11-06 22:34:43]

lgtm

https://codereview.chromium.org/63203003/diff/40001/content/browser/theme_hel...
File content/browser/theme_helper_mac.mm (right):

https://codereview.chromium.org/63203003/diff/40001/content/browser/theme_hel...
content/browser/theme_helper_mac.mm:14: #include
"content/public/common/process_type.h"
nit: not needed now

https://codereview.chromium.org/63203003/diff/40001/content/renderer/render_t...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/63203003/diff/40001/content/renderer/render_t...
content/renderer/render_thread_impl.cc:1146:
IPC_MESSAGE_HANDLER(ViewMsg_SetWebKitSharedTimersSuspended,
can you move the definition of this IPC to OS_ANDROID section as well?

[Avi (use Gerrit), 2013-11-07 15:47:52]

https://codereview.chromium.org/63203003/diff/40001/content/browser/theme_hel...
File content/browser/theme_helper_mac.mm (right):

https://codereview.chromium.org/63203003/diff/40001/content/browser/theme_hel...
content/browser/theme_helper_mac.mm:14: #include
"content/public/common/process_type.h"
On 2013/11/06 22:34:43, jam wrote:
> nit: not needed now

Done.

https://codereview.chromium.org/63203003/diff/40001/content/renderer/render_t...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/63203003/diff/40001/content/renderer/render_t...
content/renderer/render_thread_impl.cc:1146:
IPC_MESSAGE_HANDLER(ViewMsg_SetWebKitSharedTimersSuspended,
On 2013/11/06 22:34:43, jam wrote:
> can you move the definition of this IPC to OS_ANDROID section as well? 

Done.

[Avi (use Gerrit), 2013-11-07 15:49:00]

Justin, IPC check? Scrollbar display changes shouldn't be an issue, right?

[jschuh, 2013-11-07 16:27:05]

Looks like numeric settings sent browser -> renderer? If so, lgtm for ipc
security.

[Avi (use Gerrit), 2013-11-07 16:28:43]

On 2013/11/07 16:27:05, Justin Schuh wrote:
> Looks like numeric settings sent browser -> renderer? If so, lgtm for ipc
> security.

Yes. Two numeric settings as to timing behavior, one boolean as to behavior when
clicked, and one boolean to notify it whether a redraw is necessary.

[commit-bot: I haz the power, 2013-11-07 16:31:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/63203003/230001

[commit-bot: I haz the power, 2013-11-07 18:13:35]

Retried try job too often on mac_rel for step(s) browser_tests,
content_browsertests, nacl_integration, sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-07 19:31:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/63203003/530001

[commit-bot: I haz the power, 2013-11-08 08:26:19]

Change committed as 233826