base/debug/proc_maps_linux_unittest.cc - Issue 632103004: Cleanup: Better constify some strings in base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/proc_maps_linux_unittest.cc

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bad refactoring Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/proc_maps_linux_unittest.cc

diff --git a/base/debug/proc_maps_linux_unittest.cc b/base/debug/proc_maps_linux_unittest.cc

index 4be5a0f5d50d2e72380c16374de3ff2aff75d1a9..d5d1b835f4eb7081db6e81a285c676d49cde93dd 100644

--- a/base/debug/proc_maps_linux_unittest.cc

+++ b/base/debug/proc_maps_linux_unittest.cc

@@ -239,7 +239,7 @@ TEST(ProcMapsTest, ReadProcMapsNonEmptyString) {

}

TEST(ProcMapsTest, MissingFields) {

- static const char* kTestCases[] = {

+ static const char* const kTestCases[] = {

"00400000\n", // Missing end + beyond.

"00400000-0040b000\n", // Missing perms + beyond.

"00400000-0040b000 r-xp\n", // Missing offset + beyond.

@@ -261,7 +261,7 @@ TEST(ProcMapsTest, MissingFields) {

}

TEST(ProcMapsTest, InvalidInput) {

- static const char* kTestCases[] = {

+ static const char* const kTestCases[] = {

"thisisal-0040b000 rwxp 00000000 fc:00 794418 /bin/cat\n",

"0040000d-linvalid rwxp 00000000 fc:00 794418 /bin/cat\n",

"00400000-0040b000 inpu 00000000 fc:00 794418 /bin/cat\n",

« no previous file with comments | « base/debug/crash_logging_unittest.cc ('k') | base/debug/trace_event_android.cc » ('j') | no next file with comments »